Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish package upgrades for security vulnerabilities #53

Merged
merged 2 commits into from
Sep 25, 2022

Conversation

willroberts
Copy link
Collaborator

@willroberts willroberts commented Sep 25, 2022

This is the last batch of upgrades to get our Snyk vulnerabilities down to an acceptable level.

The following vulnerabilities remain:

Since the above vulnerabilities are not serious, I think we can consider our dependency upgrades largely complete, and continue to upgrade things over time as needed.

Closes #5

@willroberts
Copy link
Collaborator Author

Hmm, initially I thought the bind is not a function errors I'm seeing were a result of upgrading pretty-error, but they're still occurring after test build.

I'll hold off on merging this until later, when I have more time to track it down.

@willroberts
Copy link
Collaborator Author

willroberts commented Sep 25, 2022

Looks like it's related to the Knex upgrade. I'll check its upgrade guide and look more closely: https://github.com/knex/knex/blob/master/UPGRADING.md#upgrading-to-version-0950

@willroberts
Copy link
Collaborator Author

Since there are about 180 files to update for the Knex 0.95.0 upgrade, I'll move that to its own issue so we can move forward with the other upgrades for now.

@willroberts willroberts merged commit 01f34ec into open-duelyst:main Sep 25, 2022
@willroberts willroberts deleted the finish-security branch September 25, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APP, SERVER] Update Dependencies
1 participant