Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integration tests in Github Actions #47

Merged
merged 4 commits into from
Sep 24, 2022

Conversation

willroberts
Copy link
Collaborator

Gets integration tests working in Github Actions!

Changes:

  • Creates an Action which runs a Node.js container on an Ubuntu base, which enables us to add Postgres and Redis as sidecar services.
  • Gets database migrations working in CI by adding missing imports and removing unnecessary Firebase access.
  • Updates the imagemin-pngquant package, which was causing some build failures.
  • Cleans up test scripts with namespacing, e.g. test:unit:<directory> and test:integration:<directory> so we can better target tests.
  • Enables automatic integration tests for yarn test:integration:misc, which is currently the only set of tests which pass. We'll need to create a Firebase Realtime Database specifically for CI and resolve some lingering Knex .bind() issues to get the remaining tests passing.

I'll create an issue to reflect the need to fix and enable additional integration tests, and also close out #6 after adding another comment.

@willroberts willroberts merged commit 9570952 into open-duelyst:main Sep 24, 2022
@willroberts willroberts deleted the integ-action-2 branch September 24, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant