-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gets the API service working in ECS. Online SP now works in staging! #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets practice games working online! You can create an account and play a practice game at https://staging.duelyst.org.
This is another massive PR, with the following changes:
App Changes:
game_type
into NetworkManager'sconnect()
function, which will make it easier for us to differentiate between Game & SP services running on the same domain.app/sdk/networkManager.coffee
to split out the determination & validation of the WebSocket URL from the connection logic. Also enables retries in local development to slightly reduce code duplication.Server Changes:
FIREBASE_PROJECT_ID
,FIREBASE_CLIENT_EMAIL
, andFIREBASE_PRIVATE_KEY
. These are used in staging to supply credentials from AWS SSM Parameter Store.index.html
andregister.html
from S3 in API, with more logs and more reliability when constructing URLs/paths (which previously used string addition).isDevelopment()
/isStaging()
/isProduction()
logic to simply differentiate development vs. not development, resulting in more consistency between staging and production modes.Build Changes:
bcrypt
in API/Worker.scripts/build_staging_app.sh
).Infrastructure Changes:
dockerd
andcontainerd
consume 150MB+ already. :(NODE_ENV
, configuring Firebase, and enabling all cards in staging.