Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env flag to be able to change database engine #28

Merged
merged 2 commits into from
May 27, 2020

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Oct 17, 2019

The platform works great with postgres, just needed to make a tiny change to allow it.

  • You can't set the charset to utf8mb4 with postgres, so only set it when its mysql (default)
  • Allow database engine to be changed (MYSQL_ENGINE would be sticking to convention, but felt wrong).

I can add DATABASE_USER which defaults to MYSQL_USER which defaults to 'root' if you want make it more generic

@RyanNoelk
Copy link
Member

Thanks for the PR will test this out when I have some spare time 👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 86.459% when pulling 70da7a3 on halkeye:allow_database_model into 80a691b on open-eats:master.

@RyanNoelk RyanNoelk merged commit 57f5fcb into open-eats:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants