Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Update Fedora build instructions #110

Merged
merged 8 commits into from Aug 21, 2018
Merged

Update Fedora build instructions #110

merged 8 commits into from Aug 21, 2018

Conversation

mkungla
Copy link
Contributor

@mkungla mkungla commented Aug 1, 2018

  • Add Fedora build instructions to README
  • Update instructions in fedora/readme
  • Add gitignore with build/ entry

Correct dnf packages introduced in open-eid#89,
remove base-devel and relpace qt5qttools-devel with
qt5-qttools-devel.
@metsma
Copy link
Contributor

metsma commented Aug 13, 2018

Can you merge Ubuntu and Fedora sections in readme and add sub list for ubuntu and fedora packages at first step

- merge linux build instructions
- use reference style links
- update git instructions and replace --recursive with --recurse-submodules
@mkungla
Copy link
Contributor Author

mkungla commented Aug 13, 2018

These sections are merged, overhauled rest of the README and updated some links.

@metsma
Copy link
Contributor

metsma commented Aug 16, 2018

For me tabbed code blocks look better with raw txt file.
And not all editors do not understand github link formating and tables.
screenshot 2018-08-16 12 08 51
It should be readable with vi and other text editors also.
https://raw.githubusercontent.com/open-eid/qesteidutil/master/README.md
vs
https://raw.githubusercontent.com/open-eid/qesteidutil/39e393030eec43db18857f2e7d1382a2b0be926a/README.md
Can you change Qt links to 5.9.3 -> 5.9.6 when you already formating whole document

@mkungla
Copy link
Contributor Author

mkungla commented Aug 18, 2018

sure will do

@metsma metsma merged commit 3bb65ef into open-eid:master Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants