refactor: Reduce OTel dependencies #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austindrenski
changed the title
The `OpenFeature.Contrib.Hooks.Otel` project currently references (1) an exporter implementation which libraries should _not_ do under any normal circumstances, and (2) the main OpenTelemetry project which is excessive given all of the excellent work by the dotnet/runtime and open-telemetry/opentelemetry-dotnet teams have done over the last couple of years to ensure that the BCL types in `System.Diagnostics` conform to OTel standards. This commit removes (1) and pares down (2) to from `OpenTelemetry` to `OpenTelemetry.Api` to shrink the dependency footprint we ship to consumers. At this point, I would argue that this hooks package should meet the minimal dependency requirement for upstream inclusion in the main OpenFeature package, but deferring that discussion for now. Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski
force-pushed
the
reduce-otel-dependencies
branch
from
7d07d4a
to
26d42b9
Compare
beeme1mr
approved these changes
Jan 11, 2024
toddbaert
approved these changes
Jan 11, 2024
askpt
approved these changes
Jan 11, 2024
toddbaert
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OpenFeature.Contrib.Hooks.Otelproject currently references (1) an exporter implementation which libraries should not do under any normal circumstances, and (2) the mainOpenTelemetrypackage which is excessive given all of the excellent work by thedotnet/runtimeandopen-telemetry/opentelemetry-dotnetteams have done over the last couple of years to ensure that the BCL types inSystem.Diagnosticsconform to OTel standards.This commit removes (1) and pares down (2) to from
OpenTelemetrytoOpenTelemetry.Apito shrink the dependency footprint we ship to consumers.At this point, I would argue that this hooks package should meet the minimal dependency requirement for upstream inclusion in the main OpenFeature package, but deferring that discussion for now.