feat: Add OpenFeature.Extensions.Hosting package #181

austindrenski · 2024-01-16T22:23:32Z

Closes: #264

TODO:

codecov · 2024-01-17T16:01:59Z

Codecov Report

Attention: Patch coverage is 65.78947% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 90.82%. Comparing base (11a0333) to head (bcf19c4).
Report is 7 commits behind head on main.

❗ Current head bcf19c4 differs from pull request most recent head eda289e. Consider uploading reports for the commit eda289e to get more accurate results

Files	Patch %	Lines
...Extensions.Hosting/OpenFeatureBuilderExtensions.cs	58.10%	29 Missing and 2 partials ⚠️
src/Shared/CallerArgumentExpressionAttribute.cs	0.00%	5 Missing ⚠️
src/Shared/Check.cs	66.66%	1 Missing and 1 partial ⚠️
...sions.Hosting/Internal/OpenFeatureHostedService.cs	93.75%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   95.40%   90.82%   -4.59%     
==========================================
  Files          27       29       +2     
  Lines        1111     1068      -43     
  Branches      120      113       -7     
==========================================
- Hits         1060      970      -90     
- Misses         34       70      +36     
- Partials       17       28      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

austindrenski · 2024-01-17T16:03:23Z

FYI couple of known test failures:

DCO is intentionally broken by a temp commit containing a squash of fix: Fix ArgumentOutOfRangeException for empty hooks #187 and fix: More robust shutdown/cleanup/reset #188. Once those PRs are merged, I'll rebase and elide the temp commit.
dotnet-format is being weird about OpenFeatureHostedService and I'm pretty sure its just a sign that we need to migrate from the dotnet-format tool, to the new dotnet format that's baked into recent SDKs.
flaky unit tests: pretty sure these are all related to the async stuff, so hoping they'll be less common after chore(deps): update dependency flagsmith to v5.3.0 dotnet-sdk-contrib#184 lands, but in the meantime please just re-run the test if its failed at the time of your review.

See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <austin@austindrenski.io>

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

README.md

beeme1mr · 2024-04-30T16:02:32Z

README.md

+builder.Services.AddOpenFeature(static builder =>
+{
+    builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<FeatureProvider, SomeFeatureProvider>());
+    builder.TryAddOpenFeatureClient(SomeFeatureProvider.Name);


Is it possible to do request scoped DI? It would be really great to include an example where you sent request specific context in the client. Since it's a slightly more advanced topic, perhaps it could be included in the evaluation context section later in the doc.

It looks like it should work. Here's an example from .NET FeatureManagement.

https://github.com/microsoft/FeatureManagement-Dotnet?tab=readme-ov-file#using-httpcontext

beeme1mr · 2024-04-30T16:03:59Z

README.md

We'll need to time this merge closely with the release or move this to a separate PR that can be merged after the 2.0 release.

Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

kinyoklion · 2024-04-30T20:52:15Z

src/OpenFeature.Extensions.Hosting/Internal/OpenFeatureHostedService.cs

+    {
+        foreach (var provider in this._providers)
+        {
+            await this._api.SetProviderAsync(provider.GetMetadata().Name ?? string.Empty, provider).ConfigureAwait(false);


I don't think the meta-data name for a provider is an appropriate name here. We probably need a way to make providers that encapsulates that data.

Simple example is using one provider with two different environments.

But more than that the provider name is a different domain of names. It is the domain of the provider implementation, where client names are in the domain of the application. An application developer needs to know and assign that name.

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

austindrenski force-pushed the add-open-feature-extensions-hosting branch 5 times, most recently from c798fc8 to c295dd0 Compare January 16, 2024 22:41

This was referenced Jan 16, 2024

chore: Add common shims for new language features #182

Closed

[BUG] Api.Shutdown() hangs on reuse #186

Closed

fix: Fix ArgumentOutOfRangeException for empty hooks #187

Merged

fix: More robust shutdown/cleanup/reset #188

Merged

austindrenski force-pushed the add-open-feature-extensions-hosting branch 2 times, most recently from aa8544b to a9fd12e Compare January 17, 2024 15:59

austindrenski marked this pull request as ready for review January 17, 2024 16:03

austindrenski requested a review from a team as a code owner January 17, 2024 16:03

austindrenski force-pushed the add-open-feature-extensions-hosting branch from a9fd12e to 9821a5b Compare January 17, 2024 16:14

austindrenski mentioned this pull request Jan 17, 2024

chore: Use logging source generators #189

Merged

austindrenski force-pushed the add-open-feature-extensions-hosting branch from 9821a5b to 2eb7335 Compare January 17, 2024 18:50

austindrenski mentioned this pull request Jan 18, 2024

chore: revert breaking setProvider #190

Merged

austindrenski self-assigned this Jan 18, 2024

austindrenski force-pushed the add-open-feature-extensions-hosting branch 2 times, most recently from 828cebb to cf419bd Compare January 20, 2024 00:01

austindrenski mentioned this pull request Jan 22, 2024

[FEATURE] Promote OTel hooks from contrib to in-the-box #175

Open

austindrenski force-pushed the add-open-feature-extensions-hosting branch 7 times, most recently from 7fb289d to a2cde68 Compare January 27, 2024 20:08

austindrenski force-pushed the add-open-feature-extensions-hosting branch 2 times, most recently from 66e10b1 to 2422211 Compare January 27, 2024 20:12

feat: Add OpenFeature.Extensions.Hosting package

bcf19c4

See: open-feature/dotnet-sdk-contrib#127 Signed-off-by: Austin Drenski <austin@austindrenski.io>

austindrenski force-pushed the add-open-feature-extensions-hosting branch from 2422211 to bcf19c4 Compare January 29, 2024 13:43

askpt added this to the 2.0 (breaking) milestone Apr 8, 2024

askpt added 4 commits April 10, 2024 07:30

Merge branch 'main' into add-open-feature-extensions-hosting

694c0ff

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Removed package from merge.

0e4fe74

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Try to fix build errors.

b39f662

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Changing namespace.

85d2b36

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

askpt marked this pull request as draft April 10, 2024 07:03

askpt added 4 commits April 10, 2024 17:33

Adding the documentation.

c6de9e3

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Merge branch 'main' into add-open-feature-extensions-hosting

1fc6d51

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Merge branch 'main' into add-open-feature-extensions-hosting

90f3723

reverted version.

ed6fa59

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

askpt self-assigned this Apr 15, 2024

askpt added 3 commits April 15, 2024 16:08

Merge branch 'main' into add-open-feature-extensions-hosting

67b24d9

Merge branch 'main' into add-open-feature-extensions-hosting

31ba188

Update README.md

533aea8

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

beeme1mr reviewed Apr 30, 2024

View reviewed changes

Update README.md

cb9d0f2

Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

kinyoklion reviewed Apr 30, 2024

View reviewed changes

askpt added 7 commits May 14, 2024 17:29

Adding new example for the DI.

38ea63e

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Making class internal.

942e759

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Renamed for clarity.

496eabf

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Moved class.

00011c3

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Renamed stuff.

8cd3710

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Adding example for global hook.

a9ec44b

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Merge branch 'main' into add-open-feature-extensions-hosting

eda289e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add OpenFeature.Extensions.Hosting package #181

feat: Add OpenFeature.Extensions.Hosting package #181

austindrenski commented Jan 16, 2024 •

edited by askpt

codecov bot commented Jan 17, 2024 •

edited

austindrenski commented Jan 17, 2024 •

edited by askpt

beeme1mr Apr 30, 2024

beeme1mr Apr 30, 2024

beeme1mr Apr 30, 2024

kinyoklion Apr 30, 2024

toddbaert May 1, 2024

feat: Add OpenFeature.Extensions.Hosting package #181

Are you sure you want to change the base?

feat: Add OpenFeature.Extensions.Hosting package #181

Conversation

austindrenski commented Jan 16, 2024 • edited by askpt

Related

TODO:

codecov bot commented Jan 17, 2024 • edited

Codecov Report

austindrenski commented Jan 17, 2024 • edited by askpt

beeme1mr Apr 30, 2024

Choose a reason for hiding this comment

beeme1mr Apr 30, 2024

Choose a reason for hiding this comment

beeme1mr Apr 30, 2024

Choose a reason for hiding this comment

kinyoklion Apr 30, 2024

Choose a reason for hiding this comment

toddbaert May 1, 2024

Choose a reason for hiding this comment

austindrenski commented Jan 16, 2024 •

edited by askpt

codecov bot commented Jan 17, 2024 •

edited

austindrenski commented Jan 17, 2024 •

edited by askpt