chore: Sync ci.yml with contrib repo #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjiro
approved these changes
Jan 23, 2024
Follows open-feature#173 and open-feature/dotnet-sdk-contrib#134 to synchronize ci.yml between both repos. ```console $ diff dotnet-sdk{,-contrib}/.github/workflows/ci.yml ``` Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski
force-pushed
the
sync-ci-flow-with-contrib
branch
from
710f42e
to
a2d93e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 23 23
Lines 954 954
Branches 105 105
=======================================
Hits 892 892
Misses 38 38
Partials 24 24 ☔ View full report in Codecov by Sentry. |
askpt
approved these changes
Jan 27, 2024
askpt
pushed a commit
that referenced
this pull request
Jan 30, 2024
Signed-off-by: Austin Drenski <austin@austindrenski.io> Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
beeme1mr
pushed a commit
that referenced
this pull request
Mar 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.0](v1.4.1...v1.5.0) (2024-03-12) ### 🐛 Bug Fixes * Add targeting key ([#231](#231)) ([d792b32](d792b32)) * Fix NU1009 reference assembly warning ([#222](#222)) ([7eebcdd](7eebcdd)) * invalid editorconfig ([#244](#244)) ([3c00757](3c00757)) ### ✨ New Features * Flag metadata ([#223](#223)) ([fd0a541](fd0a541)) * implement in-memory provider ([#232](#232)) ([1082094](1082094)) ### 🧹 Chore * bump spec version badge ([#246](#246)) ([ebf5552](ebf5552)) * cleanup unused usings 🧹 ([#240](#240)) ([cdc1bee](cdc1bee)) * **deps:** update actions/upload-artifact action to v4.3.0 ([#203](#203)) ([0a7e98d](0a7e98d)) * **deps:** update actions/upload-artifact action to v4.3.1 ([#233](#233)) ([cfaf1c8](cfaf1c8)) * **deps:** update codecov/codecov-action action to v3.1.5 ([#209](#209)) ([a509b1f](a509b1f)) * **deps:** update codecov/codecov-action action to v3.1.6 ([#226](#226)) ([a577a80](a577a80)) * **deps:** update dependency coverlet.collector to v6.0.1 ([#238](#238)) ([f2cb67b](f2cb67b)) * **deps:** update dependency fluentassertions to v6.12.0 ([#215](#215)) ([2c237df](2c237df)) * **deps:** update dependency microsoft.net.test.sdk to v17.8.0 ([#216](#216)) ([4cb3ae0](4cb3ae0)) * **deps:** update dependency nsubstitute to v5.1.0 ([#217](#217)) ([3be76cd](3be76cd)) * **deps:** update dependency openfeature.contrib.providers.flagd to v0.1.8 ([#211](#211)) ([c1aece3](c1aece3)) * **deps:** update xunit-dotnet monorepo ([#236](#236)) ([fa25ece](fa25ece)) * Enable Central Package Management (CPM) ([#178](#178)) ([249a0a8](249a0a8)) * Enforce coding styles on build ([#242](#242)) ([64699c8](64699c8)) * More sln cleanup ([#206](#206)) ([bac3d94](bac3d94)) * SourceLink is built-in for .NET SDK 8.0.100+ ([#198](#198)) ([45e2c86](45e2c86)) * Sync ci.yml with contrib repo ([#196](#196)) ([130654b](130654b)) * Sync release.yml with ci.yml following [#173](#173) ([#195](#195)) ([eba8848](eba8848)) ### 📚 Documentation * fix hook ecosystem link ([#229](#229)) ([cc6c404](cc6c404)) * update the feature table key ([f8724cd](f8724cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #173 and open-feature/dotnet-sdk-contrib#134 to synchronize
ci.ymlbetween both repos.$ diff dotnet-sdk{,-contrib}/.github/workflows/ci.ymlStory here is a little convoluted, but basically this repo already had the linux and windows tests in one workflow, so for #173 I was able to just condition the new
packagingjob on bothunit-tests-linuxandunit-tests-windowscompleting successfully.However, prior to open-feature/dotnet-sdk-contrib#134, the contrib repo had separate workflow files for its respective linux and windows tests, so as part of open-feature/dotnet-sdk-contrib#134, I merged those separate workflows into one workflow and, at the same time, rewrote them to use a job matrix.
For PR consistency, I almost included the same job matrix update as part of #173, but held off in the spirit of doing one thing at a time. So, with that, this PR now syncs the two
ci.ymlfiles so both will exactly match after open-feature/dotnet-sdk-contrib#134 is merged (anticipated sometime today).Additionally, this PR also includes the
nuget.configandCONTRIBUTING.mdupdates from open-feature/dotnet-sdk-contrib#134. Arguably, these may not be needed by this repo, but I'm including them here for (1) consistency, (2) to promote visibility, and (3) to help advertise that these are available if required and/or helpful to future contributors/bug reporters.