Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update OpenFeature.sln #202

Merged
merged 3 commits into from
Jan 23, 2024
Merged

build: Update OpenFeature.sln #202

merged 3 commits into from
Jan 23, 2024

Conversation

askpt
Copy link
Member

@askpt askpt commented Jan 23, 2024

This PR

  • This PR fixes an issue related to opening the project in VSCode.

Related Issues

See log output here:

Failed at 'Open a solution with environment service' (5ms) with error: Error: An item with the same key has already been added. Key: 90e7ead3-251e-4490-af78-e758e33518e5
Failed at 'Open a solution' (8ms) with error: SolutionOpenError: Run into errors while opening the solution: Error: An item with the same key has already been added. Key: 90e7ead3-251e-4490-af78-e758e33518e5
Failed to open solution SolutionOpenError: Run into errors while opening the solution: Error: An item with the same key has already been added. Key: 90e7ead3-251e-4490-af78-e758e33518e5

How to test

Just open VSCode and check it's working again.

@askpt askpt requested a review from a team as a code owner January 23, 2024 18:05
@askpt askpt changed the title Update OpenFeature.sln build: Update OpenFeature.sln Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eba8848) 93.50% compared to head (7b48ccc) 93.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          23       23           
  Lines         954      954           
  Branches      105      105           
=======================================
  Hits          892      892           
  Misses         38       38           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@austindrenski austindrenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess someone must have originally added this manually, then?

@askpt can you run these commands locally, and assuming they do what I expect, check in the results?

git reset @~ --hard
dotnet sln remove test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj
dotnet sln add test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Copy link
Member Author

askpt commented Jan 23, 2024

I guess someone must have originally added this manually, then?

@askpt can you run these commands locally, and assuming they do what I expect, check in the results?

git reset @~ --hard
dotnet sln remove test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj
dotnet sln add test/OpenFeature.E2ETests/OpenFeature.E2ETests.csproj

Did this now. Please review again.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this too during a review, but was able to work around it by disabling an extension. I was going to dig into it but assumed it was just me. Thanks.

@beeme1mr beeme1mr merged commit 3722dec into main Jan 23, 2024
12 checks passed
@toddbaert toddbaert deleted the askpt/fix-sln branch January 23, 2024 21:18
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this pull request Jan 23, 2024
austindrenski added a commit to austindrenski/open-feature-dotnet-sdk that referenced this pull request Jan 26, 2024
See: open-feature#202

Signed-off-by: Austin Drenski <austin@austindrenski.io>
austindrenski added a commit that referenced this pull request Jan 26, 2024
See: #202

Signed-off-by: Austin Drenski <austin@austindrenski.io>
askpt added a commit that referenced this pull request Jan 30, 2024
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
askpt pushed a commit that referenced this pull request Jan 30, 2024
See: #202

Signed-off-by: Austin Drenski <austin@austindrenski.io>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants