Feat: Implement seperate methods for integer and double #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GetDoubleValue, GetDoubleDetails and ResolveDoubleValue to FeatureProvider interface and FeatureClient - Rename GetNumberValue, GetNumberDetails to GetIntegerValue, GetIntegerDetails - Add tests for new methods Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 99.32% 99.66% +0.34%
==========================================
Files 15 15
Lines 297 303 +6
Branches 22 22
==========================================
+ Hits 295 302 +7
+ Partials 2 1 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
beeme1mr
approved these changes
Aug 4, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the recent spec change open-feature/spec#116
and FeatureClient