chore: update readme #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include examples of implmenting hooks and providers - Include CONTRIBUTING.md Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 99.33% 99.34%
=======================================
Files 15 16 +1
Lines 303 305 +2
Branches 24 25 +1
=======================================
+ Hits 301 303 +2
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
beeme1mr
reviewed
Aug 10, 2022
CONTRIBUTING.md
Outdated
| @@ -0,0 +1,107 @@ | |||
| # Contributing to the OpenFeature project | |||
|
|
|||
| Our community meetings are held fortnightly on Thursdays at 4pm. Check the [OpenFeature community calendar](https://calendar.google.com/calendar/u/0?cid=MHVhN2kxaGl2NWRoMThiMjd0b2FoNjM2NDRAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ) for specific dates and for the Zoom meeting links. | |||
There was a problem hiding this comment.
This section is already in the readme. I would recommend having it in one place so it doesn't accidently get out of sync.
README.md
Outdated
|
|
||
| ## License | ||
|
|
||
| Apache License 2.0 |
There was a problem hiding this comment.
Could you please link to this the license?
Avoid updates to this in the future, users can refer to calendar linke Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
Remove duplicate data Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
|
@beeme1mr Thanks for the review, I've addressed above. |
beeme1mr
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Evenson 2031163+benjiro@users.noreply.github.com