Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt telemetry setup error handling #1315

Merged
merged 5 commits into from
May 27, 2024

Conversation

bacherfl
Copy link
Contributor

Closes #1194

This PR adapts the service setup to not fail when encountering an error in the telemetry setup.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 155bf59
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/6654b7f37e017b000810d2c7
😎 Deploy Preview https://deploy-preview-1315--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.71%. Comparing base (1c530ab) to head (155bf59).
Report is 65 commits behind head on main.

Files Patch % Lines
core/pkg/telemetry/metrics.go 87.50% 1 Missing ⚠️
...agd/pkg/service/flag-evaluation/connect_service.go 87.50% 1 Missing ⚠️
...agd/pkg/service/middleware/metrics/http_metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   73.69%   78.71%   +5.02%     
==========================================
  Files          32       36       +4     
  Lines        3140     2824     -316     
==========================================
- Hits         2314     2223      -91     
+ Misses        717      466     -251     
- Partials      109      135      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bacherfl bacherfl marked this pull request as ready for review May 22, 2024 08:48
@bacherfl bacherfl requested a review from a team as a code owner May 22, 2024 08:48
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 22, 2024
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I left few comments which once resolved I can approve this :)

@Kavindu-Dodan Kavindu-Dodan self-requested a review May 23, 2024 20:17
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@toddbaert toddbaert merged commit 20bcb78 into open-feature:main May 27, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request May 27, 2024
toddbaert pushed a commit that referenced this pull request Jun 6, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.10.3</summary>

##
[0.10.3](flagd/v0.10.2...flagd/v0.10.3)
(2024-06-06)


### 🧹 Chore

* adapt telemetry setup error handling
([#1315](#1315))
([20bcb78](20bcb78))
* fix unit tests and ensure their execution
([#1316](#1316))
([25041c0](25041c0))
</details>

<details><summary>core: 0.9.3</summary>

##
[0.9.3](core/v0.9.2...core/v0.9.3)
(2024-06-06)


### 🐛 Bug Fixes

* fixes store merge when selector is used
([#1322](#1322))
([ed5025d](ed5025d))


### 🧹 Chore

* adapt telemetry setup error handling
([#1315](#1315))
([20bcb78](20bcb78))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve telemetry error handling
4 participants