feat: parse new featureflagconfiguration CRD structure #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft to ensure it's merged at the same time as the OFO component. Ready for review |
|
The tests/linting fails because the PR needs updating to include the version of OFO that includes the CRD spec change. |
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
skyerus
force-pushed
the
issue-204_parse-featureflagconfiguration-crd
branch
from
362c65b
to
84bcfcb
Compare
skyerus
changed the title
toddbaert
approved these changes
Nov 3, 2022
toddbaert
reviewed
Nov 3, 2022
| @@ -40,28 +40,32 @@ func (k *Sync) Source() string { | |||
| } | |||
|
|
|||
| func (k *Sync) Fetch(ctx context.Context) (string, error) { | |||
| state := "{}" | |||
|
Not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Parses the featureflagconfiguration CRD structure changes (more detail here).
Related Issues
Fixes #204
Notes
To be release in conjunction with open-feature/open-feature-operator#207
Follow-up Tasks
How to test