Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: isolate interfaces from SDK to improve testability #268

Merged
merged 7 commits into from
May 29, 2024
Merged

feat: isolate interfaces from SDK to improve testability #268

merged 7 commits into from
May 29, 2024

Commits on May 23, 2024

  1. isolate interfaces from SDK 

    Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
    @Kavindu-Dodan
    Kavindu-Dodan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1741a31 View commit details
    Browse the repository at this point in the history

  2. solidify interfaces to match OF API & client 

    Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
    @Kavindu-Dodan
    Kavindu-Dodan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3fd0a70 View commit details
    Browse the repository at this point in the history

  3. improve code docs 

    Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
    @Kavindu-Dodan
    Kavindu-Dodan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    38d7175 View commit details
    Browse the repository at this point in the history

  4. review changes 

    Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
    @Kavindu-Dodan
    Kavindu-Dodan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    9409d5f View commit details
    Browse the repository at this point in the history

  5. make eventExecutor internal 

    Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
    @Kavindu-Dodan
    Kavindu-Dodan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4c70c41 View commit details
    Browse the repository at this point in the history

  6. make scopedCallback internal 

    Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
    @Kavindu-Dodan
    Kavindu-Dodan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    0ce5af8 View commit details
    Browse the repository at this point in the history

  7. fix rebase conflict 

    Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
    @Kavindu-Dodan
    Kavindu-Dodan committed May 23, 2024
    Configuration menu
    Copy the full SHA
    c7ede79 View commit details
    Browse the repository at this point in the history