feat: avoid star imports via checkstyle (#817)

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com> Co-authored-by: madhead <siarhei.krukau@gmail.com>
open-feature · Jun 11, 2024 · 249225f · 249225f
1 parent 9b7dc9a
commit 249225f
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/checkstyle.xml b/checkstyle.xml
@@ -51,7 +51,7 @@
     <module name="TreeWalker">
         <!-- needed for SuppressWarningsFilter -->
         <module name="SuppressWarningsHolder" />
-        
+
         <module name="SuppressWarnings">
             <property name="id" value="checkstyle:suppresswarnings"/>
         </module>
@@ -62,7 +62,10 @@
                         default="checkstyle-xpath-suppressions.xml" />
             <property name="optional" value="true"/>
         </module>
-
+
+
+        <module name="AvoidStarImport" />
+
         <module name="OuterTypeFilename"/>
         <module name="IllegalTokenText">
             <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>

diff --git a/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvVarProvider.java b/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvVarProvider.java
@@ -1,6 +1,11 @@
 package dev.openfeature.contrib.providers.envvar;
 
-import dev.openfeature.sdk.*;
+import dev.openfeature.sdk.EvaluationContext;
+import dev.openfeature.sdk.FeatureProvider;
+import dev.openfeature.sdk.Metadata;
+import dev.openfeature.sdk.ProviderEvaluation;
+import dev.openfeature.sdk.Reason;
+import dev.openfeature.sdk.Value;
 import dev.openfeature.sdk.exceptions.FlagNotFoundError;
 import dev.openfeature.sdk.exceptions.ParseError;
 import dev.openfeature.sdk.exceptions.ValueNotConvertableError;

diff --git a/...var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvironmentKeyTransformer.java b/...var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvironmentKeyTransformer.java
@@ -1,6 +1,7 @@
 package dev.openfeature.contrib.providers.envvar;
 
-import java.util.function.*;
+import java.util.function.Function;
+import java.util.function.UnaryOperator;
 
 import lombok.RequiredArgsConstructor;
 import org.apache.commons.lang3.StringUtils;

diff --git a/...provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java b/...provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java
@@ -1,6 +1,11 @@
 package dev.openfeature.contrib.providers.jsonlogic;
 
-import dev.openfeature.sdk.*;
+import dev.openfeature.sdk.EvaluationContext;
+import dev.openfeature.sdk.FeatureProvider;
+import dev.openfeature.sdk.Metadata;
+import dev.openfeature.sdk.ProviderEvaluation;
+import dev.openfeature.sdk.Reason;
+import dev.openfeature.sdk.Value;
 import dev.openfeature.sdk.exceptions.ParseError;
 import io.github.jamsesso.jsonlogic.JsonLogic;
 import io.github.jamsesso.jsonlogic.JsonLogicException;