-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: various improvements as suggested by sonar #674
Merged
Kavindu-Dodan
merged 1 commit into
open-feature:main
from
Kavindu-Dodan:chore/various-improvements
Feb 15, 2024
Merged
chore: various improvements as suggested by sonar #674
Kavindu-Dodan
merged 1 commit into
open-feature:main
from
Kavindu-Dodan:chore/various-improvements
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
commented
Feb 9, 2024
...src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java
Show resolved
Hide resolved
163908f
to
4843490
Compare
toddbaert
reviewed
Feb 9, 2024
...test/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/SemVerTest.java
Show resolved
Hide resolved
toddbaert
approved these changes
Feb 9, 2024
toddbaert
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, thanks for doing this!
thisthat
reviewed
Feb 12, 2024
...src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java
Show resolved
Hide resolved
1d000c7
to
43e876f
Compare
Waiting pipeline to be stable through #681 |
43e876f
to
118e7c5
Compare
thisthat
approved these changes
Feb 15, 2024
118e7c5
to
9661cb6
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
9661cb6
to
e2af8f1
Compare
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…o v2.7.10 (open-feature#674) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Contains improvements to code smells and issues suggested by sonarqube.