Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flagd] Default port to 8015 if in-process resolver is used. #809

Closed
toddbaert opened this issue Jun 7, 2024 · 2 comments · Fixed by #810
Closed

[flagd] Default port to 8015 if in-process resolver is used. #809

toddbaert opened this issue Jun 7, 2024 · 2 comments · Fixed by #810
Assignees
@zedadyna
Labels
good first issue Good for newcomers

Comments

@toddbaert
Copy link
Member

The flagd provider defaults to RPC mode and the corresponding port (8013) using the evaluation proto. If the in-process resolver is selected, it operates in in-process mode using the sync proto, but still uses port 8013, instead of defaulting to the correct port (8015, for the sync proto).

We should improve the configuration by defaulting to port 8015 if the in-process resolver is selected.
@toddbaert toddbaert added the good first issue Good for newcomers label Jun 7, 2024
@zedadyna
Copy link
Contributor

zedadyna commented Jun 7, 2024

I like to take this one

@thisthat
Copy link
Member

thisthat commented Jun 7, 2024

Hey @zedadyna, thanks for picking this :) I'm assigning this to you then :)

zedadyna added a commit to zedadyna/java-sdk-contrib that referenced this issue Jun 7, 2024
@zedadyna
feat: [flagd] Default port to 8015 if in-process resolver is used.
adf1c75 
closes: open-feature#809
@zedadyna zedadyna mentioned this issue Jun 7, 2024
Merged
zedadyna added a commit to zedadyna/java-sdk-contrib that referenced this issue Jun 7, 2024
@zedadyna
feat: [flagd] Default port to 8015 if in-process resolver is used.
5f2a504 
closes: open-feature#809
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
zedadyna added a commit to zedadyna/java-sdk-contrib that referenced this issue Jun 7, 2024
@zedadyna @alexandraoberaigner
feat: [flagd] Default port to 8015 if in-process resolver is used.
4f693de 
closes: open-feature#809
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
Co-authored-by: Alexandra Oberaigner <alexandra.oberaigner@dynatrace.com>
zedadyna added a commit to zedadyna/java-sdk-contrib that referenced this issue Jun 11, 2024
@zedadyna @alexandraoberaigner
feat: [flagd] Default port to 8015 if in-process resolver is used.
acea7f7 
closes: open-feature#809
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
Co-authored-by: Alexandra Oberaigner <alexandra.oberaigner@dynatrace.com>
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
zedadyna added a commit to zedadyna/java-sdk-contrib that referenced this issue Jun 11, 2024
@zedadyna @alexandraoberaigner
feat: [flagd] Default port to 8015 if in-process resolver is used.
ec263ac 
closes: open-feature#809
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
Co-authored-by: Alexandra Oberaigner <alexandra.oberaigner@dynatrace.com>
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
zedadyna added a commit to zedadyna/java-sdk-contrib that referenced this issue Jun 11, 2024
@zedadyna @alexandraoberaigner
feat: [flagd] Default port to 8015 if in-process resolver is used.
7a4b3fc 
closes: open-feature#809
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
Co-authored-by: Alexandra Oberaigner <alexandra.oberaigner@dynatrace.com>
Signed-off-by: Daniel Zehetner <daniel.zehetner@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zedadyna zedadyna

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: [flagd] Default port to 8015 if in-process resolver is used. zedadyna/java-sdk-contrib
3 participants
@thisthat @toddbaert @zedadyna