chore: javadoc and tests for api, context #942
Conversation
toddbaert
force-pushed
the
chore/more-tests-and-doc
branch
from
3a5bc97
to
e43f7c8
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
============================================
+ Coverage 94.98% 95.21% +0.22%
- Complexity 383 384 +1
============================================
Files 36 36
Lines 877 877
Branches 53 53
============================================
+ Hits 833 835 +2
+ Misses 24 23 -1
+ Partials 20 19 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| assertEquals("4", merged.getValue("common5").asString(), "invocation merge is incorrect"); | ||
| assertEquals("4", merged.getValue("common6").asString(), "invocation merge is incorrect"); | ||
|
|
||
| c.getBooleanValue("key", false, invocationCtx); |
There was a problem hiding this comment.
instead of the specific "getMergedContext" method, I simply used a spy here.
| @@ -17,18 +15,13 @@ public DoSomethingProvider(ImmutableMetadata flagMetadata) { | |||
| this.flagMetadata = flagMetadata; | |||
| } | |||
|
|
|||
| EvaluationContext getMergedContext() { | |||
There was a problem hiding this comment.
This method is no longer needed, spies work better.
| public Metadata getProviderMetadata() { | ||
| return getProvider().getMetadata(); | ||
| } | ||
|
|
||
| /** | ||
| * Get metadata about a registered provider using the client name. |
There was a problem hiding this comment.
| * Get metadata about a registered provider using the client name. | |
| * Get metadata about a registered provider using the client domain. |
To match with domain scoping PR - #934 :)
There was a problem hiding this comment.
Please see client name vs domain usage in other places
There was a problem hiding this comment.
I wanted to avoid as many clashes with that PR as possible...
But maybe it's better to merge that first.
There was a problem hiding this comment.
Nice set of improvements
Please see this to avoid conflicts in documentation
Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
|
@toddbaert I think this can be rebased an considered for 1.8.1 release :) |
This PR contains no functional changes, it:
fixes: #939