fix: fixes an issue where OFREP does not send content type headers (#882

) Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
open-feature · Apr 16, 2024 · b3289e5 · b3289e5
1 parent 5c22142
commit b3289e5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/libs/shared/ofrep-core/src/lib/api/ofrep-api.ts b/libs/shared/ofrep-core/src/lib/api/ofrep-api.ts
@@ -106,8 +106,12 @@ export class OFREPApi {
     evaluationRequest?: EvaluationRequest,
     options?: RequestOptions,
   ): Promise<OFREPApiEvaluationResult> {
+    const headers = new Headers(options?.headers);
+    headers.append('Content-Type', 'application/json; charset=utf-8');
+
     const request = new Request(`${this.baseUrl}/ofrep/v1/evaluate/flags/${flagKey}`, {
       ...options,
+      headers,
       method: 'POST',
       body: JSON.stringify(evaluationRequest ?? {}),
     });
@@ -126,8 +130,12 @@ export class OFREPApi {
     evaluationRequest?: EvaluationRequest,
     options?: RequestOptions,
   ): Promise<OFREPApiBulkEvaluationResult> {
+    const headers = new Headers(options?.headers);
+    headers.append('Content-Type', 'application/json; charset=utf-8');
+
     const request = new Request(`${this.baseUrl}/ofrep/v1/evaluate/flags`, {
       ...options,
+      headers: headers,
       method: 'POST',
       body: JSON.stringify(evaluationRequest ?? {}),
     });

diff --git a/libs/shared/ofrep-core/src/test/handlers.ts b/libs/shared/ofrep-core/src/test/handlers.ts
@@ -17,6 +17,11 @@ export const handlers = [
         throw HttpResponse.text(undefined, { status: 400 });
       }
 
+      const contentTypeHeader = info.request.headers.get('Content-Type');
+      if (contentTypeHeader?.toLowerCase() !== 'application/json; charset=utf-8') {
+        throw HttpResponse.text('Wrong content type', { status: 415 });
+      }
+
       const authHeader = info.request.headers.get('Authorization');
       const expectedAuthHeader = requestBody.context?.['expectedAuthHeader'] ?? null;
 
@@ -115,6 +120,11 @@ export const handlers = [
         throw HttpResponse.text(undefined, { status: 400 });
       }
 
+      const contentTypeHeader = info.request.headers.get('Content-Type');
+      if (contentTypeHeader?.toLowerCase() !== 'application/json; charset=utf-8') {
+        throw HttpResponse.text('Wrong content type', { status: 415 });
+      }
+
       const authHeader = info.request.headers.get('Authorization');
       const expectedAuthHeader = requestBody.context?.['expectedAuthHeader'] ?? null;