Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use copy-anything for deepClone to be compatible with nodeJS before v17 #429

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix: use copy-anything for deepClone to be compatible with nodeJS before v17 #429

merged 2 commits into from
Jun 28, 2023

Conversation

thomaspoignant
Copy link
Member

@thomaspoignant thomaspoignant commented Jun 28, 2023 •
edited
Loading

This PR

  • use copy-anything for deepClone to be compatible with nodeJS before v17

Fixes #428

@thomaspoignant
fix: use lodash to stay compatible with nodeJS before v17
48b5ce1 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant requested a review from a team as a code owner June 28, 2023 07:32
@thomaspoignant thomaspoignant mentioned this pull request Jun 28, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 28, 2023
Closed
toddbaert
toddbaert requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-feature/js-sdk-contrib/pull/429/files#r1245375078

@thomaspoignant
Using copy-anithing instead of lodash
0d6d58d 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant changed the title fix: use lodash for deepClone to be compatible with nodeJS before v17 fix: use copy-anything for deepClone to be compatible with nodeJS before v17 Jun 28, 2023
@thomaspoignant
Copy link
Member Author

Thanks @beeme1mr and @toddbaert to have catch the usage of lodash.
I've imported copy-anything that is more lightweight and will handle the copy.

@beeme1mr beeme1mr merged commit b4a7ffe into open-feature:main Jun 28, 2023
5 checks passed
@thomaspoignant thomaspoignant deleted the fix-428-replace-structuredClone branch June 28, 2023 19:28
@github-actions github-actions bot mentioned this pull request Jun 28, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newest npm go-feature-flag-provider version incompatible with older NodeJS versions
3 participants
@thomaspoignant @beeme1mr @toddbaert