Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement web-sdk #367

Closed
toddbaert opened this issue Mar 2, 2023 · 0 comments · Fixed by #353
Closed

Implement web-sdk #367

toddbaert opened this issue Mar 2, 2023 · 0 comments · Fixed by #353
Assignees

Comments

@toddbaert
Copy link
Member

toddbaert commented Mar 2, 2023

Currently, lack of a web-sdk is blocking a few experiments, (see: open-feature/playground#179 and open-feature/playground#178) for instance.

We should implement a web-sdk similar to what is proposed, and publish it only as an experimental artifact to NPM (npm publish --tag experimental with an experimental version number).

@toddbaert toddbaert self-assigned this Mar 2, 2023
toddbaert added a commit that referenced this issue Mar 9, 2023
This PR transfroms this repo into a monorepo, with server (exsiting),
client (new) and shared (new) packages.

There are no tests yet for the client. Publishing _should_ work but is
yet untested.

The experimental web SDK will be published as `0.0.1-experimental` and
features:

- native browser events
- "close" functionality (implemented in server as well)
- async context setting
- sync evaluation

Though we want `close` and `events` in the server SDK, they are not
implemented in this PR (though it would be very easy to do so and I've
left TODO's about it). **There are no functional changes in the server
SDK with this PR.**

Here is a [direct
link](https://github.com/open-feature/js-sdk/blob/experimental-web-sdk/README.md)
to the README.md changes.

**_I'm not expecting reviewers to go through this with a fine-toothed
comb. Most of the changes are just establishing the monorepo, and the
functional stuff in the new web-sdk is just experimental._**.

Closes: #367

---------

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant