Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize/Helm Cleanup / Support Multiple ImagePullSecrets #665

Closed
toddbaert opened this issue Jun 4, 2024 · 2 comments · Fixed by #666
Closed

Kustomize/Helm Cleanup / Support Multiple ImagePullSecrets #665

toddbaert opened this issue Jun 4, 2024 · 2 comments · Fixed by #666
Labels
help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

As discussed in #655, the fact we use both Kustomize and Helm causes us some pain and limitations. We should see if we can completely remove kustomize in favor of pure Helm, and as a first-fruit of this effort, allow multiple ImagePullSecrets to be defined (instead of the current limitation to one).

One request I'll have is to add supporting the array of imagePullSecrets to the backlog for OpenFeature. Inevitably the build process will change and evolve, and when it does, this use-case will just become part of it.

Originally posted by @cpitstick-latai in #655 (comment)

@toddbaert toddbaert added the help wanted Extra attention is needed label Jun 4, 2024
@cpitstick-latai
Copy link
Contributor

What would the removal of the kustomize layer look like? I feel like it's there for a reason, and there will likely be dragons in that removal process...

@toddbaert
Copy link
Member Author

toddbaert commented Jun 5, 2024

@thisthat and I spend some time looking into this. I actually don't think it's reasonably possible right now unless we want to manually maintain a chart (which I'm really reluctant to do).

The main issue is that kubebuilder is the thing that generates our kustomize layer from go-code (which is really useful). There's no way to have kubebuilder generate helm YET, but there is a feature/plugin in discussion.

I think for now, we may have to settle for my most recent hack, which doesn't solve the root of the mess but at least allows for multiple ImagePullSecrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants