Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test: No-op client mutators #59

Closed
tcarrio opened this issue Dec 31, 2022 · 0 comments · Fixed by #65
Closed

Unit test: No-op client mutators #59

tcarrio opened this issue Dec 31, 2022 · 0 comments · Fixed by #65
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tcarrio
Copy link
Member

tcarrio commented Dec 31, 2022

You can set hooks and evaluation context but these are non-actionable, since they don't truly impact the return values. Add unit tests to cover these.
@tcarrio tcarrio added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 31, 2022
tcarrio added a commit that referenced this issue Jan 2, 2023
@tcarrio
test: cases for NoOpClient
8e8fb1a 
Fixes #59

Signed-off-by: Tom Carrio <tom@carrio.dev>
@tcarrio tcarrio mentioned this issue Jan 2, 2023
Merged
@tcarrio tcarrio closed this as completed in 5dc93aa Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: coverage improvements and chores open-feature/php-sdk
1 participant
@tcarrio