fix: specfinder was using an incorrect regex #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an erroneus quote in there which was breaking the regex Signed-off-by: Justin Abrahms <justin@abrah.ms>
justinabrahms
force-pushed
the
specfinder-fix
branch
from
ad6c1ca
to
7f9f626
Compare
sheepduke
approved these changes
Apr 16, 2024
justinabrahms
added a commit
that referenced
this pull request
Apr 20, 2024
Signed-off-by: Justin Abrahms <justin@abrah.ms>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
We had an erroneus quote in there which was breaking the regex
How to test
python3 spec_finder.pyand validate 1.1.1 isn't listed.