Merging context #117
Merged
Merging context #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
justinabrahms,
agentgonzo,
beeme1mr,
benjiro,
dabeeeenster,
davejohnston,
moredip,
skyerus,
thomaspoignant and
weyert
beeme1mr
approved these changes
Jul 27, 2022
skyerus
reviewed
Jul 28, 2022
toddbaert
force-pushed
the
feat/merging-context
branch
2 times, most recently
from
f1e4e1c
to
29442ee
Compare
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
force-pushed
the
feat/merging-context
branch
from
29442ee
to
241207b
Compare
agentgonzo
approved these changes
Aug 1, 2022
This was referenced Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a section about merging context. This is already partially done in the node-sdk and dotnet-sdk, and there's a comment about it in the java-sdk.
For this reason I think this is a fairly minor and even predicted change so I haven't created an OFEP... but let me know if you think this is a big deal:tm: