Removed EvaluationOptions from FeatureProvider method signatures #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James-Milligan <james@omnant.co.uk>
james-milligan
requested review from
oleg-nenashev and
toddbaert
as code owners
toddbaert
requested review from
justinabrahms,
beeme1mr,
benjiro,
davejohnston,
InTheCloudDan,
skyerus and
thomaspoignant
toddbaert
approved these changes
Aug 24, 2022
|
@beeme1mr this is a breaking change (though a minor one)... I know we're not using release plz here, but do we need to annotate the title at all? Should we be validating titles? |
justinabrahms
approved these changes
Aug 24, 2022
beeme1mr
approved these changes
Aug 24, 2022
|
@james-milligan, can you mention that this is a breaking change in the PR comment? I'll make sure to include that information on the release notes. |
|
We have approval but let's wait to merge this until tomorrow (Aug 25th, 2022) to give others a chance to provide feedback. |
skyerus
approved these changes
Aug 24, 2022
benjiro
approved these changes
Aug 24, 2022
beeme1mr
approved these changes
Aug 25, 2022
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
#133