Locale aware datepicker #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be used for the datepicker locale-aware bits
sergei-maertens
force-pushed
the
feature/433-locale-aware-datepicker
branch
from
8de3fad
to
a4f06c9
Compare
CharString
requested changes
Jun 29, 2023
The tests run in the NL locale, so they should also type in the NL format.
And improve the implementation by doing everything in the event handler, saving a render cycle.
sergei-maertens
force-pushed
the
feature/433-locale-aware-datepicker
branch
from
2d2ef42
to
7d9899f
Compare
CharString
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #433
This makes the input field for the date picker locale aware and more forgiving.