Test results latest build

[sergei-maertens]

Tested against version 5a8a30a.

• Test form: demo-sprint-11-testing on the Maykin test env
• Admin interface in regular browser window
• Filling out the form in incognito window, Brave (Chromium 96)

---

Form designer

• BUG: Configuring appointments: added a phone number field in a different step, re-used a generic appointment fields step -> cannot configure the phone number component (dropdown does not change state) @sergei-maertens (fixed in 1ed8b77)
• Products/prices tab: add support for complex logic rule triggers #1190
• the JSON logic complex trigger editor is difficult to use #1191
  • manual formatting (newlines, indentation) is reset when valid JSON is detected which outputs it all on a single line
  • font not being code/monospace makes it hard to read/edit the JSON
  • cursor jumps around once valid JSON is entered
  • basically currently the best way is to define the JSON in a code editor and then copy paste it into the form field
• BUG: the complex JSON logic uses validation for simple logic at the moment, effectively making and and combined logic rules impossible to use. Caused by refactor with pricing/form logic & added validators. (fixed in a78d6b9)

Filling out the form

• BUG: Logging in with DigiD (login optional) brings the SDK into an infinite loading loop. Unsure what causes it, might be pre-fill related? @sergei-maertens (fixed in More fixes w/r to Formio data immutability open-forms-sdk#142)
  • It works when starting the form as anonymous user (!)
• BUG: Multiple inputs (textfield) are broken (again) because of immutable state. The + add another button click triggers this (likely fixed by [#887] Fixed immutable state data leaking into formio and erroring when mutated open-forms-sdk#136) fix: More fixes w/r to Formio data immutability open-forms-sdk#142
• BUG: Fieldset show/hide based on checkbox with default value true behaved a bit weird, but may be because of invalid logic configuration. To double check.
• BUG: the WYSIWYG editor for the confirmation page template correctly allows arbitrary hyperlinks (filtering should only be done for templates going to e-mails w/r to phishing protection), however when the SDK renders this the URL appears to have been filtered out. Possibly some sanitation happens that shouldn't, OR the validator should be slapped on that field instead so users know to add it to the netloc allow list. @Bartvaderkin (fixed by 190c09c)
• ??: background processing to quite a long time - might be because test server is overloaded, might be because of cold caches -> check again soon-ish
• IMPROVEMENT: submissions admin show form step dropdown for every submission step inline. This will get worse the more form-steps there are -> should be raw_id_field widget @Bartvaderkin or @joeribekker
• There's a console.log that was left in FormStep.js that shouldn't be
• BUG: changing an appointment is very broken
  • The product data is not (pre)selected in the dropdown
  • The location data is not (pre)selected in the dropdown
  • The selected date is not pre-selected and because of that displayed in a "system" format (ISO-8601 instead of human readable)
  • The selected time is not pre-selected and because of that displayed in a "system" format (ISO-8601 instead of human readable)
  • It does not appear that the options are properly loaded from the backend.
• BUG: changing an appointment that was already paid still makes you pay again could not reproduce on re-test
• BUG: number field with comma's in overview page is displayed with dot (.) instead comma (,) decimal separator. Also same problem in the PDF confirmation @Bartvaderkin (fixed in [#1174] Fixed number and currency localisation in get_printable_data() #1185 and [open-formulieren/open-forms#1174] Fixed localisation of number and currency components open-forms-sdk#145)
• BUG: confirmation PDF order does not meet order of form steps (regression of Order of fields in the submission summary and PDF confirmation and formatting #750) @Bartvaderkin (fixed in [#750, #1174] Fixed ordering of FormStep/components in Form.iter_components #1186)
• BUG (?): appointment change does not require re-authentication, but might be because anonymous option is available too

[sergei-maertens]

The issue where earlier selected data for appointments is not visible when changing the appointment is because of a dirty hack we did/do. Instead of sending just the PK of the selected product/location, we send a rich object to get the label for display to. However, this bites us in the buttocks when editing it, as Formio cannot map this to an option.

Data for a fresh form with initial appointment product/location selection:

{
    "product": 37,
    "locatie": "",
    "afspraakDatum": "",
    "afspraakTijdstip": ""
}

Data for an existing appointment:

{
    "product": {
        "name": "Belastingen algemeen",
        "identifier": "37"
    },
    "locatie": {
        "name": "Gemeente Horst aan de Maas",
        "identifier": "1"
    },
    "afspraakDatum": "2022-01-24",
    "afspraakTijdstip": "2022-01-24T11:30:00+01:00"
}