Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow payment to be disabled for certain users #2617

Closed
LaurensBurger opened this issue Jan 27, 2023 · 1 comment · Fixed by open-formulieren/open-forms-sdk#641 or #3841
Closed

Allow payment to be disabled for certain users #2617

LaurensBurger opened this issue Jan 27, 2023 · 1 comment · Fixed by open-formulieren/open-forms-sdk#641 or #3841
Assignees
@vaszig
Labels
enhancement owner: utrecht
Milestone
Release 2.6.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Jan 27, 2023 •
edited by alextreme

Thema / Theme

Form designer

Omschrijving / Description

internal: utr 39 + lv 70

Utr: As a form designer i want to create forms that (for instance) need to be paid directly when user is auth_bsn, but when the user is auth_kvk we do not require this payment and instead send a invoice. The former is an example, I would like to be able to use logic in order to determine if payment is necessary or not

LV: We would like to skip/disable payment under certain conditions - this condition could be when the form is completed by someone else (like a employee) or when the user has no possibility to pay online.

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

This could be achieved by creating a condition where if the price = 0, payment gets disabled. At the moment 0 will start a payment request for 0.
@LaurensBurger LaurensBurger added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Jan 27, 2023
@joeribekker joeribekker added this to the Release 2.6.0 milestone Jan 22, 2024
@joeribekker
Copy link
Contributor

Refinement: Let's do amount=0 means no payment

@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jan 29, 2024
vaszig added a commit to open-formulieren/open-forms-sdk that referenced this issue Feb 2, 2024
@vaszig
[open-formulieren/open-forms#2617] Changed needsPayment to be retriev…
06b0d37 
…ed from submission

The way to show the payment step in the progress indicator and to start
the payment form was through the form. Since we want to have access to
the price rules as well, we had to have access to the submission. So,
the submission is now the one which tells us if a form needs payment.
@vaszig vaszig mentioned this issue Feb 2, 2024
Merged
vaszig added a commit that referenced this issue Feb 2, 2024
@vaszig
[#2617] Define if form needs payment in submission as well
bd2f12d 
With this we evaluate the pricing rules (if they exist) in the
submission method in order to see if a payment is still needed to be
done, since a rule could result to zero(0) amount and no payment.
@vaszig vaszig mentioned this issue Feb 2, 2024
Merged
vaszig added a commit that referenced this issue Feb 5, 2024
@vaszig
[#2617] Define if form needs payment in submission as well
58224e8 
With this we evaluate the pricing rules (if they exist) in the
submission method in order to see if a payment is still needed to be
done, since a rule could result to zero(0) amount and no payment.
vaszig added a commit that referenced this issue Feb 5, 2024
@vaszig
[#2617] Added validation for product price > 0
8e89172
vaszig added a commit that referenced this issue Feb 5, 2024
@vaszig
[#2617] Define if form needs payment in submission as well
16fae5f 
With this we evaluate the pricing rules (if they exist) in the
submission method in order to see if a payment is still needed to be
done, since a rule could result to zero(0) amount and no
payment.Additional check that the product has valid price.
vaszig added a commit that referenced this issue Feb 5, 2024
@vaszig
[#2617] Define if form needs payment in submission as well
51beac5 
With this we evaluate the pricing rules (if they exist) in the
submission method in order to see if a payment is still needed to be
done, since a rule could result to zero(0) amount and no
payment.Additional check that the product has valid price.
vaszig added a commit that referenced this issue Feb 5, 2024
@vaszig
[#2617] PR feedback
70790b0
vaszig added a commit that referenced this issue Feb 7, 2024
@vaszig
[#2617] Fixed-refactored duplicate code
abed37a
vaszig added a commit that referenced this issue Feb 7, 2024
@vaszig
[#2617] Added missing comment in get_submission_price
32f27d5
vaszig added a commit that referenced this issue Feb 7, 2024
@vaszig
[#2617] Added extra assertion for product price
539451d
sergei-maertens pushed a commit that referenced this issue Feb 7, 2024
@vaszig @sergei-maertens
[#2617] Define if form needs payment in submission as well
cdc9a92 
With this we evaluate the pricing rules (if they exist) in the
submission method in order to see if a payment is still needed to be
done, since a rule could result to zero(0) amount and no
payment.Additional check that the product has valid price.
sergei-maertens pushed a commit that referenced this issue Feb 7, 2024
@vaszig @sergei-maertens
[#2617] PR feedback
fc0d62f
sergei-maertens pushed a commit that referenced this issue Feb 7, 2024
@vaszig @sergei-maertens
[#2617] Fixed-refactored duplicate code
839fdfc
sergei-maertens pushed a commit that referenced this issue Feb 7, 2024
@vaszig @sergei-maertens
[#2617] Added missing comment in get_submission_price
9136722
sergei-maertens pushed a commit that referenced this issue Feb 7, 2024
@vaszig @sergei-maertens
[#2617] Added extra assertion for product price
40f66e5
sergei-maertens added a commit that referenced this issue Feb 7, 2024
@sergei-maertens
💚 [#2617] Fix broken test setup
1dd9a88
sergei-maertens added a commit that referenced this issue Feb 7, 2024
@sergei-maertens
Merge pull request #3841 from open-formulieren/feature/2617-allow-pay…
550b58a 
…ment-when-amount-bigger-than-zero

[#2617] Disable payment if price is zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaszig vaszig

Labels
enhancement owner: utrecht
Projects
Development
Archived in project
Milestone
Release 2.6.0
4 participants
@joeribekker @alextreme @vaszig @LaurensBurger