Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handling of old cases from ServiceFetchAction.eval #3052

Closed
CharString opened this issue May 3, 2023 · 0 comments · Fixed by #3979
Closed

Remove handling of old cases from ServiceFetchAction.eval #3052

CharString opened this issue May 3, 2023 · 0 comments · Fixed by #3979

Comments

@CharString
Copy link
Contributor

Previously in the 2.1.x release of the Service Fetch the admin UI of the ServiceFetchAction logic action, a ServiceFetchConfiguration was not tied to a User Defined Variable and the action allowed to change the values of both variables and components directly. This has changed with the configuration modal.

ServiceFetchAction.eval() still contains a shim that handles the old case. This should be tackled with a datamigration and/or handled in the serializer/import step.

This change in behaviour should also be documented #2884 , both in the manual and in test cases.

SilviaAmAm added a commit that referenced this issue Mar 6, 2024
SilviaAmAm added a commit that referenced this issue Mar 7, 2024
SilviaAmAm added a commit that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant