Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the text next to the label for optional fields #3201

Closed
SilviaAmAm opened this issue Jun 29, 2023 · 2 comments · Fixed by #3717
Closed

Change the text next to the label for optional fields #3201

SilviaAmAm opened this issue Jun 29, 2023 · 2 comments · Fixed by #3717
Assignees
@SilviaAmAm
Labels
enhancement owner: den-haag triage Issue needs to be validated. Remove this label if the issue considered valid.

Comments

@SilviaAmAm
Copy link
Contributor

Thema / Theme

Frontend

Omschrijving / Description

DH Taiga 530

Currently, DH has (optioneel) next to form fields that are optional (and no asterisks next to required fields).

However, DH would like this to become (niet verplicht).

In the code:
https://github.com/open-formulieren/open-forms-sdk/blob/main/src/formio/templates/checkbox.ejs#L21
https://github.com/open-formulieren/open-forms-sdk/blob/main/src/formio/templates/label.ejs#L8

Added value / Toegevoegde waarde

This has to do with which words are expected to be known to someone with B1 dutch.

Aanvullende opmerkingen / Additional context

No response
@SilviaAmAm SilviaAmAm added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement owner: den-haag labels Jun 29, 2023
@sergei-maertens
Copy link
Member

sergei-maertens commented Jun 29, 2023 •
edited

This also affects the react-intl translations in the SDK! See https://github.com/open-formulieren/open-forms-sdk/blob/main/src/components/forms/Label.js#L21

@hlmr-erik hlmr-erik mentioned this issue Dec 14, 2023
Closed
@SilviaAmAm SilviaAmAm self-assigned this Dec 27, 2023
@SilviaAmAm
Copy link
Contributor Author

This looks like it was mostly done in this issue #3651

SilviaAmAm added a commit that referenced this issue Dec 27, 2023
@SilviaAmAm
💬 [#3201] Replace a last 'optioneel' with 'niet verplicht'
8c89b50
@SilviaAmAm SilviaAmAm mentioned this issue Dec 27, 2023
Merged
sergei-maertens added a commit that referenced this issue Dec 27, 2023
@sergei-maertens
Merge pull request #3717 from open-formulieren/fix/3201-missing-optio…
6df1fa4 
…neel

💬 [#3201] Replace a last 'optioneel' with 'niet verplicht'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
enhancement owner: den-haag triage Issue needs to be validated. Remove this label if the issue considered valid.
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

💬 [#3201] Replace a last 'optioneel' with 'niet verplicht' open-formulieren/open-forms
2 participants
@sergei-maertens @SilviaAmAm