Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic rule logging #3239

Closed
joeribekker opened this issue Jul 10, 2023 · 4 comments · Fixed by #3819
Closed

Remove logic rule logging #3239

joeribekker opened this issue Jul 10, 2023 · 4 comments · Fixed by #3819

Comments

@joeribekker
Copy link
Contributor

joeribekker commented Jul 10, 2023

Investigate if this feature is used (look at access.log).

As opposed to #2998

@joeribekker joeribekker added this to the Release 2.3.0 milestone Jul 10, 2023
@joeribekker joeribekker self-assigned this Jul 10, 2023
@sergei-maertens
Copy link
Member

Checked on our production servers, with all access logs concatenated into a single file:

/tmp/accesslogs# wc -l access.log
880296 access.log
/tmp/accesslogs# grep -E 'GET /admin/submissions/submission/[0-9]+/logs/logic/' access.log | wc -l
0

So these logs are literally not used at all for our SaaS customers.

@sergei-maertens
Copy link
Member

Same check on test environments (limited access logs to /admin/ URLs):

5 / 15533 are logic log views, which is 0.03%. I think we can remove this.

@joeribekker
Copy link
Contributor Author

Refinement: @sergei-maertens will bring this up in refinement at DH

@sergei-maertens
Copy link
Member

We can remove it before building an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants