Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nieuwe installaties hebben Engelse teksten (e-mail) bij de Nederlandse instellingen #3308

Closed
joeribekker opened this issue Jul 26, 2023 · 5 comments · Fixed by #3433
Closed

Nieuwe installaties hebben Engelse teksten (e-mail) bij de Nederlandse instellingen #3308

joeribekker opened this issue Jul 26, 2023 · 5 comments · Fixed by #3433
Assignees
@sergei-maertens
Labels
bug Something isn't working
Milestone
Release 2.1.7

Comments

@joeribekker
Copy link
Contributor

Product versie / Product version

2.1.4

Omschrijf het probleem / Describe the bug

image

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response
@joeribekker joeribekker added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jul 26, 2023
@joeribekker joeribekker added this to the Release 2.1.5 milestone Jul 26, 2023
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jul 26, 2023
@sergei-maertens sergei-maertens modified the milestones: Release 2.1.5, 2.1.6 Jul 26, 2023
@joeribekker
Copy link
Contributor Author

Refinement: Most likely similar to the copy-issue, runtime the default language is retrieved which can differ.

@joeribekker
Copy link
Contributor Author

Hint might be here: https://django-modeltranslation.readthedocs.io/en/latest/usage.html?highlight=default#auto-population-modes-1

@bart-maykin
Copy link
Contributor

Opened an issue in the django-modeltranslation library to add support for model.field default value translation on model creation.

@sergei-maertens
Copy link
Member

@bart-maykin you can implement the feature 😄

@sergei-maertens sergei-maertens removed their assignment Aug 16, 2023
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Aug 16, 2023
sergei-maertens added a commit that referenced this issue Aug 30, 2023
@sergei-maertens
🐛 [#3308] Fix and add test for dynamic defaults in translatable model…
b1aab9d 
… fields

The default values are not properly localized at runtime for the statement
checkbox field labels, fixing it...
sergei-maertens added a commit that referenced this issue Aug 30, 2023
@sergei-maertens
✅ [#3308] Test that each translatable field can produce an appropriat…
1fd1e76 
…e default

Each field should have a default value in the language of the field. These
are taken from our default translation catalogs.
sergei-maertens added a commit that referenced this issue Aug 30, 2023
@sergei-maertens
🌐 [#3308] Ensure that translatable model field defaults are localized
3cceefa
@sergei-maertens sergei-maertens mentioned this issue Aug 30, 2023
Merged
sergei-maertens added a commit that referenced this issue Sep 8, 2023
@sergei-maertens
⬆️ [#3308] Bump django-modeltranslation
3d192c6
sergei-maertens added a commit that referenced this issue Sep 8, 2023
@sergei-maertens
🐛 [#3308] Fix and add test for dynamic defaults in translatable model…
7d01b15 
… fields

The default values are not properly localized at runtime for the statement
checkbox field labels, fixing it...
sergei-maertens added a commit that referenced this issue Sep 8, 2023
@sergei-maertens
✅ [#3308] Test that each translatable field can produce an appropriat…
c8ea7ad 
…e default

Each field should have a default value in the language of the field. These
are taken from our default translation catalogs.
sergei-maertens added a commit that referenced this issue Sep 8, 2023
@sergei-maertens
🌐 [#3308] Ensure that translatable model field defaults are localized
b59fa29
sergei-maertens added a commit that referenced this issue Sep 8, 2023
@sergei-maertens
⬆️ [#3308] Bump django-modeltranslation
f34b4e3
sergei-maertens added a commit that referenced this issue Sep 8, 2023
@sergei-maertens
🗃️ [#3308] Added missing migration
bd43b84
@sergei-maertens sergei-maertens removed the needs-backport Fix must be backported to stable release branch label Sep 8, 2023
@sergei-maertens
Copy link
Member

Migrations are involved, no longer backporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
bug Something isn't working
Projects
Development
Archived in project
Milestone
Release 2.1.7
Development

Successfully merging a pull request may close this issue.

Fix model field default values not being translated correctly open-formulieren/open-forms
3 participants
@joeribekker @sergei-maertens @bart-maykin