Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation warning for empty "Toelichtingssjabloon" #3375

Closed
LaurensBurger opened this issue Aug 16, 2023 · 1 comment · Fixed by #3432
Closed

Translation warning for empty "Toelichtingssjabloon" #3375

LaurensBurger opened this issue Aug 16, 2023 · 1 comment · Fixed by #3432
Assignees
@bart-maykin
Labels
bug Something isn't working
Milestone
Release 2.4.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Aug 16, 2023 •
edited

Product versie / Product version

2.1.5

Omschrijf het probleem / Describe the bug

internal: db16
When the "Toelichtingssjabloon" is empty it will return a translation warning for both languages.
This should not happen when both versions (en + nl) of the field are empty.
image

Since the "toelichtingsjabloon" is optional and often left blank, this wanring should only occur if one version is different from the other.
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Aug 16, 2023
@sergei-maertens
Copy link
Member

Refinement: suggested fix accepted. We should also check other translatable, optional fields for similar behaviour.

@sergei-maertens sergei-maertens removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Aug 21, 2023
@bart-maykin bart-maykin self-assigned this Aug 24, 2023
@sergei-maertens sergei-maertens added this to the Release 2.4.0 milestone Aug 24, 2023
bart-maykin added a commit that referenced this issue Aug 29, 2023
@bart-maykin
🐛 [#3375] fixed issue that would not show explanation template transl…
b193ed3 
…ation warnings
bart-maykin added a commit that referenced this issue Aug 30, 2023
@bart-maykin
🐛 [#3375] fixed issue that would not show explanation template transl…
07f9f9f 
…ation warnings
@bart-maykin bart-maykin mentioned this issue Aug 30, 2023
Merged
bart-maykin added a commit that referenced this issue Aug 31, 2023
@bart-maykin
🐛 [#3375] fixed issue that would not show explanation template transl…
a670d15 
…ation warnings
bart-maykin added a commit that referenced this issue Aug 31, 2023
@bart-maykin
🐛 [#3375] fixed issue that would not show explanation template transl…
2e9c25b 
…ation warnings
bart-maykin added a commit that referenced this issue Aug 31, 2023
@bart-maykin
🐛 [#3375] fixed issue that would not show explanation template transl…
9d51986 
…ation warnings
bart-maykin added a commit that referenced this issue Sep 1, 2023
@bart-maykin
🐛 [#3375] fixed issue that would not show explanation template transl…
24296c4 
…ation warnings
sergei-maertens added a commit that referenced this issue Sep 1, 2023
@sergei-maertens
Merge pull request #3432 from open-formulieren/feature/3375-unique-to…
a431151 
…gether-optional-translation-fields

🐛 [#3375] fixed issue that would not show explanation template translation warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bart-maykin bart-maykin

Labels
bug Something isn't working
Projects
Development
Archived in project
Milestone
Release 2.4.0
3 participants
@sergei-maertens @bart-maykin @LaurensBurger