Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations: Date/Datetime components warn for translations of "dd-mm-yyyy" & "dd-MM-yyyy HH:mm" #3382

Closed
LaurensBurger opened this issue Aug 18, 2023 · 1 comment · Fixed by #3824
Closed

Translations: Date/Datetime components warn for translations of "dd-mm-yyyy" & "dd-MM-yyyy HH:mm" #3382

LaurensBurger opened this issue Aug 18, 2023 · 1 comment · Fixed by #3824
Assignees
@vaszig
Labels
bug Something isn't working owner: utrecht topic: form builder
Milestone
Release 2.6.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Aug 18, 2023 •
edited

Product versie / Product version

2.1.x - 2.2.x

Omschrijf het probleem / Describe the bug

Date and Datetime components in a form with translations will always show requirements for translations.
This is cause by their placeholders:
"placeholder": "dd-mm-yyyy",
"placeholder": "dd-MM-yyyy HH:mm",

This can only be solved by removing the placeholder.
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Aug 18, 2023
@sergei-maertens
Copy link
Member

sergei-maertens commented Aug 21, 2023 •
edited

Refinement:

  • placeholder cannot be changed at form design time
  • form design reports that placeholder is missing translation
  • placeholder cannot be translated in translations tab

-> proper solution would be to exclude placeholder from translations, which is hard in the current form builder

postponing this to the new form builder

  • to check: the client-side translation should change when you change locale

@sergei-maertens sergei-maertens added topic: form builder and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Aug 21, 2023
@SilviaAmAm SilviaAmAm self-assigned this Jan 22, 2024
@joeribekker joeribekker changed the title Transltions: Date/Datetime components warn for tranlstions of "dd-mm-yyyy" & "dd-MM-yyyy HH:mm" Translations: Date/Datetime components warn for translations of "dd-mm-yyyy" & "dd-MM-yyyy HH:mm" Jan 22, 2024
@joeribekker joeribekker assigned vaszig and unassigned SilviaAmAm Jan 22, 2024
@joeribekker joeribekker added this to the Release 2.6.0 milestone Jan 22, 2024
vaszig added a commit that referenced this issue Jan 29, 2024
@vaszig
[#3382] Fixed translation warnings for date,datetime placeholders
d10593c 
In the new form builder (see types as well) Date and Datetime schemas do not have
placeholder as a property. So, this is handled here for the warnings in
the admin.
@vaszig vaszig mentioned this issue Jan 29, 2024
Merged
sergei-maertens pushed a commit that referenced this issue Feb 2, 2024
@vaszig @sergei-maertens
[#3382] Fixed translation warnings for date,datetime placeholders
1ad5dbc 
In the new form builder (see types as well) Date and Datetime schemas do not have
placeholder as a property. So, this is handled here for the warnings in
the admin.

Co-authored-by: @Viicos
sergei-maertens pushed a commit that referenced this issue Feb 2, 2024
@vaszig @sergei-maertens
[#3382] Fixed translation warnings for date,datetime placeholders
a194bec 
In the new form builder (see types as well) Date and Datetime schemas do not have
placeholder as a property. So, this is handled here for the warnings in
the admin.

Co-authored-by: @Viicos
sergei-maertens added a commit that referenced this issue Feb 2, 2024
@sergei-maertens
Merge pull request #3824 from open-formulieren/fix/3382-date-datetime…
35583c0 
…-translations-warnings

[#3382] Translation warnings for date,datetime placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaszig vaszig

Labels
bug Something isn't working owner: utrecht topic: form builder
Projects
Development
Archived in project
Milestone
Release 2.6.0
Development

Successfully merging a pull request may close this issue.

[#3382] Translation warnings for date,datetime placeholders open-formulieren/open-forms
5 participants
@joeribekker @sergei-maertens @SilviaAmAm @vaszig @LaurensBurger