Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies page: Styling missing (font, buttons etc.) #3420

Closed
LaurensBurger opened this issue Aug 25, 2023 · 1 comment · Fixed by #3440
Closed

Cookies page: Styling missing (font, buttons etc.) #3420

LaurensBurger opened this issue Aug 25, 2023 · 1 comment · Fixed by #3440
Assignees
@vaszig
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Milestone
Release 2.0.11 FINAL

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Aug 25, 2023 •
edited

Product versie / Product version

2.1.x, 2.2.x, 2.3.x

Omschrijf het probleem / Describe the bug

The /cookies/ page has it's own style and does not change aling with the values of the design-tokens.
This becomes obvious by just looking at the buttons:
image

But it seems the font is also "standard" (Roboto?) and does not change along with the font change with design tokens:
Front:
image

Cookies:
image
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Aug 25, 2023
@sergei-maertens sergei-maertens added needs-backport Fix must be backported to stable release branch and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Aug 28, 2023
@sergei-maertens
Copy link
Member

sergei-maertens commented Aug 28, 2023 •
edited

Refinement: the SDK stylesheet is not loaded on this page, causing the broken styles.

@sergei-maertens sergei-maertens added this to the Release 2.0.11 FINAL milestone Aug 28, 2023
vaszig added a commit that referenced this issue Aug 31, 2023
@vaszig
[#3420] Started with fixing cookies page styling
0099ce8
@vaszig vaszig mentioned this issue Aug 31, 2023
Merged
vaszig added a commit that referenced this issue Sep 1, 2023
@vaszig
[#3420] Fixed classes in html pages
7f56f5c
vaszig added a commit that referenced this issue Sep 4, 2023
@vaszig
[#3420] Fixed failing test
f5b750c
sergei-maertens pushed a commit that referenced this issue Sep 6, 2023
@vaszig @sergei-maertens
[#3420] Fixed classes and CSS in cookie overview html pages
c8fa018 
This is still an in-between state while the SDK CSS is being
reworked. Utimately, this should all just use NL Design System.
sergei-maertens added a commit that referenced this issue Sep 6, 2023
@sergei-maertens
Merge pull request #3440 from open-formulieren/fix/3420-missing-style…
1c26de3 
…s-in-cookies-page

[#3420] Fix missing styling on Cookies page
sergei-maertens pushed a commit that referenced this issue Sep 6, 2023
@vaszig @sergei-maertens
[#3420] Fixed classes and CSS in cookie overview html pages
b8100d6 
This is still an in-between state while the SDK CSS is being
reworked. Utimately, this should all just use NL Design System.

Backport-of: #3440
sergei-maertens pushed a commit that referenced this issue Sep 6, 2023
@vaszig @sergei-maertens
[#3420] Fixed classes and CSS in cookie overview html pages
745eceb 
This is still an in-between state while the SDK CSS is being
reworked. Utimately, this should all just use NL Design System.

Backport-of: #3440
sergei-maertens pushed a commit that referenced this issue Sep 6, 2023
@vaszig @sergei-maertens
[#3420] Fixed classes and CSS in cookie overview html pages
57bfd45 
This is still an in-between state while the SDK CSS is being
reworked. Utimately, this should all just use NL Design System.

Backport-of: #3440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaszig vaszig

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Projects
Development
Archived in project
Milestone
Release 2.0.11 FINAL
Development

Successfully merging a pull request may close this issue.

[#3420] Fix missing styling on Cookies page open-formulieren/open-forms
3 participants
@sergei-maertens @vaszig @LaurensBurger