Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with the case where Haal Centraal returns a partner without BSN #3524

Closed
SilviaAmAm opened this issue Oct 4, 2023 · 1 comment · Fixed by #3561
Closed

Deal with the case where Haal Centraal returns a partner without BSN #3524

SilviaAmAm opened this issue Oct 4, 2023 · 1 comment · Fixed by #3561

Comments

@SilviaAmAm
Copy link
Contributor

One of the test BSN of Haal Centraal v2 gives this back:

{"type":"RaadpleegMetBurgerservicenummer","personen":[{"kinderen":[],"partners":[{"naam":{"voornamen":"Jean Marie","geslachtsnaam":"Beaudelaire","voorletters":"J.M."}}]}]}

However, we always expect a BSN for the family members component.

In Stuff BG, we ignore any family member without BSN, so maybe we should do the same thing.

@joeribekker
Copy link
Contributor

Refinement:

  1. Lets make the behaviour consistent and ignore those without a BSN
  2. Let's add a help-text in the relevant component (preferably a bit more visible than behind a tooltip) that indicates this behaviour
  3. Joeri will raise this issue with the stakeholders on how to deal with this.

@joeribekker joeribekker added this to the Release 2.4.0 milestone Oct 9, 2023
SilviaAmAm added a commit that referenced this issue Oct 30, 2023
sergei-maertens pushed a commit that referenced this issue Oct 30, 2023
sergei-maertens added a commit that referenced this issue Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants