Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new button design tokens #3566

Closed
sergei-maertens opened this issue Oct 31, 2023 · 0 comments · Fixed by #3570
Closed

Migrate to new button design tokens #3566

sergei-maertens opened this issue Oct 31, 2023 · 0 comments · Fixed by #3570
Assignees
@sergei-maertens
Milestone
Release 2.4.0

Comments

@sergei-maertens
Copy link
Member

open-formulieren/open-forms-sdk#462 dropped the support for our (custom) button design tokens in favour of nl design system (utrecht-button) design tokens.

Any instances that specified custom colors need to specify the appropriate NL DS tokens now - where possible we can update those through a data migration.
@sergei-maertens sergei-maertens added this to the Release 2.4.0 milestone Oct 31, 2023
@sergei-maertens sergei-maertens self-assigned this Oct 31, 2023
sergei-maertens added a commit that referenced this issue Oct 31, 2023
@sergei-maertens
📝 [#3566] Document button design tokens migration
037d268
sergei-maertens added a commit that referenced this issue Oct 31, 2023
@sergei-maertens
👽 [#3566] Implement data migration to replace custom button tokens wi…
5641d73 
…th NL DS utrecht-button tokens
@sergei-maertens sergei-maertens mentioned this issue Oct 31, 2023
Merged
sergei-maertens added a commit that referenced this issue Oct 31, 2023
@sergei-maertens
⬆️ [#3566] Upgrade design tokens package to latest version
f829620
sergei-maertens added a commit that referenced this issue Oct 31, 2023
@sergei-maertens
👽 [#3566] Update classnames for button on cookies page
27db8d1
sergei-maertens added a commit that referenced this issue Oct 31, 2023
@sergei-maertens
👽 [#3566] Update remaining openforms-button -> utrecht-button
c024c90
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
📝 [#3566] Document button design tokens migration
71ce1cf
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
👽 [#3566] Implement data migration to replace custom button tokens wi…
691ab6a 
…th NL DS utrecht-button tokens
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
⬆️ [#3566] Upgrade design tokens package to latest version
c335243
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
👽 [#3566] Update classnames for button on cookies page
2d23d06
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
👽 [#3566] Update remaining openforms-button -> utrecht-button
2699450
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
📝 [#3566] Document button design tokens migration
942b5ff
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
👽 [#3566] Implement data migration to replace custom button tokens wi…
f2b453d 
…th NL DS utrecht-button tokens
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
⬆️ [#3566] Upgrade design tokens package to latest version
285121c
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
👽 [#3566] Update classnames for button on cookies page
5d6f711
sergei-maertens added a commit that referenced this issue Nov 1, 2023
@sergei-maertens
👽 [#3566] Update remaining openforms-button -> utrecht-button
fb0a02e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
None yet
Projects
Development
Archived in project
Milestone
Release 2.4.0
Development

Successfully merging a pull request may close this issue.

Handle button refactor breaking changes open-formulieren/open-forms
1 participant
@sergei-maertens