Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zgw zaken: Incorrect mapping of fields #3580

Closed
Tracked by #3578
LaurensBurger opened this issue Nov 7, 2023 · 1 comment · Fixed by #3586
Closed
Tracked by #3578

Zgw zaken: Incorrect mapping of fields #3580

LaurensBurger opened this issue Nov 7, 2023 · 1 comment · Fixed by #3586
Assignees
@CharString
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Milestone
Release 2.4.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Nov 7, 2023 •
edited

Product versie / Product version

2.3.2

Omschrijf het probleem / Describe the bug

open-forms/src/openforms/registrations/contrib/zgw_apis/plugin.py

Line 157 in 0cfac75

"betrokkeneIdentificatie.verblijfsadres.woonplaatsNaam": RegistrationAttribute.initiator_woonplaats,

certain fields in OF zgw create zaak plugin are named incorrect:
"betrokkeneIdentificatie.verblijfsadres.woonplaatsNaam":
"betrokkeneIdentificatie.verblijfsadres.huisnummer":
"betrokkeneIdentificatie.verblijfsadres.postcode":
The should instead be named:
"betrokkeneIdentificatie.verblijfsadres.wplWoonplaatsNaam":
"betrokkeneIdentificatie.verblijfsadres.aoaHuisnummer":
"betrokkeneIdentificatie.verblijfsadres.aoaPostcode":

as per:
https://github.com/VNG-Realisatie/gemma-zaken/blob/3873bebd4c93d6803b0cda8f43dcf47d3cc56bd8/api-specificatie/zrc/1.5.x/openapi.yaml#L13605
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 7, 2023
@LaurensBurger LaurensBurger mentioned this issue Nov 7, 2023
Open
2 tasks
@alextreme
Copy link
Contributor

Note that all 6 fields for verblijfsadres are incorrect, not only the 3 mentioned:

    "betrokkeneIdentificatie.verblijfsadres.woonplaatsNaam": RegistrationAttribute.initiator_woonplaats,
    "betrokkeneIdentificatie.verblijfsadres.postcode": RegistrationAttribute.initiator_postcode,
    "betrokkeneIdentificatie.verblijfsadres.straatnaam": RegistrationAttribute.initiator_straat,
    "betrokkeneIdentificatie.verblijfsadres.huisnummer": RegistrationAttribute.initiator_huisnummer,
    "betrokkeneIdentificatie.verblijfsadres.huisletter": RegistrationAttribute.initiator_huisletter,
    "betrokkeneIdentificatie.verblijfsadres.huisnummertoevoeging": RegistrationAttribute.initiator_huisnummer_toevoeging

Also verified in Zaken API v1.0/v1.2.1

https://github.com/VNG-Realisatie/gemma-zaken/blob/3873bebd4c93d6803b0cda8f43dcf47d3cc56bd8/api-specificatie/zrc/1.2.x/1.2.1/openapi.yaml

VerblijfsAdres: required: - aoaIdentificatie - wplWoonplaatsNaam - gorOpenbareRuimteNaam - aoaHuisnummer type: object properties: aoaIdentificatie: title: Aoa identificatie description: De unieke identificatie van het OBJECT type: string maxLength: 100 minLength: 1 wplWoonplaatsNaam: title: Wpl woonplaats naam type: string maxLength: 80 minLength: 1 gorOpenbareRuimteNaam: title: Gor openbare ruimte naam description: Een door het bevoegde gemeentelijke orgaan aan een OPENBARE RUIMTE toegekende benaming type: string maxLength: 80 minLength: 1 aoaPostcode: title: Aoa postcode type: string maxLength: 7 aoaHuisnummer: title: Aoa huisnummer type: integer maximum: 99999 minimum: 0 aoaHuisletter: title: Aoa huisletter type: string maxLength: 1 aoaHuisnummertoevoeging: title: Aoa huisnummertoevoeging type: string maxLength: 4 inpLocatiebeschrijving: title: Inp locatiebeschrijving type: string maxLength: 1000

@CharString CharString self-assigned this Nov 8, 2023
@CharString CharString added needs-backport Fix must be backported to stable release branch and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 8, 2023
@sergei-maertens sergei-maertens added this to the Release 2.4.0 milestone Nov 8, 2023
CharString added a commit that referenced this issue Nov 8, 2023
@CharString
🐛[#3580] Fix zrc rol_create
2f7a634 
I assume `gorOpenbareRuimteNaam` is semantically the same as streetname.

This fixes the reported bug. But doesn't test against the spec.

Closes #3580
@CharString CharString mentioned this issue Nov 8, 2023
Merged
@CharString CharString linked a pull request Nov 8, 2023 that will close this issue
🐛[#3580] Fix zrc rol_create #3586
Merged
@CharString CharString mentioned this issue Nov 8, 2023
Open
CharString added a commit that referenced this issue Nov 8, 2023
@CharString
✅[#3580] Pass test... in a *bad* way
ee5629b 
Make the test green, but it asserts incorrect behaviour!

See #3587 for a real solution.
@sergei-maertens sergei-maertens mentioned this issue Nov 8, 2023
Closed
17 tasks
sergei-maertens added a commit that referenced this issue Nov 9, 2023
@sergei-maertens
Merge pull request #3586 from open-formulieren/3580-zgw-zaken-incorre…
22f4135 
…ct-mapping-of-fields

🐛[#3580] Fix zrc rol_create
sergei-maertens pushed a commit that referenced this issue Nov 9, 2023
@CharString @sergei-maertens
🐛[#3580] Fix zrc rol_create
1ae4078 
I assume `gorOpenbareRuimteNaam` is semantically the same as streetname.

This fixes the reported bug. But doesn't test against the spec.

Closes #3580

Backport-of: #3586
sergei-maertens pushed a commit that referenced this issue Nov 9, 2023
@CharString @sergei-maertens
🐛[#3580] Fix zrc rol_create
6d86766 
I assume `gorOpenbareRuimteNaam` is semantically the same as streetname.

This fixes the reported bug. But doesn't test against the spec.

Closes #3580

Backport-of: #3586
sergei-maertens pushed a commit that referenced this issue Nov 9, 2023
@CharString @sergei-maertens
🐛[#3580] Fix zrc rol_create
d0da1b0 
I assume `gorOpenbareRuimteNaam` is semantically the same as streetname.

This fixes the reported bug. But doesn't test against the spec.

Closes #3580

Backport-of: #3586
@LaurensBurger LaurensBurger mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharString CharString

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch
Projects
Development
Archived in project
Milestone
Release 2.4.0
Development

Successfully merging a pull request may close this issue.

🐛[#3580] Fix zrc rol_create open-formulieren/open-forms
4 participants
@alextreme @CharString @sergei-maertens @LaurensBurger