Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects API integration: pausing and restarting DigiD form causes hashed BSNs to be sent to the Objects API (only Demo BSN?) #3613

Closed
alextreme opened this issue Nov 15, 2023 · 3 comments · Fixed by #3642
Assignees
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: den-haag
Milestone

Comments

@alextreme
Copy link
Contributor

alextreme commented Nov 15, 2023

Product versie / Product version

2.4.0

Omschrijf het probleem / Describe the bug

Submitted and analysed via DH OF Taiga 617

When pausing and restarting a DigiD form which uses the Objects API registration backend the bsn is sent to the Objects API as a hashed value.

After testing we can only reproduce this using the Demo BSN DigiD registration backend. Requires further analysis to first determine why this occurred for DH.

This seemed to be a regression of #2301 from Open Formulieren 1.1.8.

Further analysis from @LaurensBurger and me, this issue is applicable for:

  • Demo BSN DigiD

This is not applicable:

  • DigiD-SAML (because requires you to relogin)
  • DigiD-OIDC within 15 minutes (continue during the same DigiD session)
  • DigiD-OIDC >15 minutes (new DigiD session)

Unknown, to be tested:

  • eHerkenning-SAML?
  • eHerkenning-OIDC?

image

@alextreme alextreme added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 15, 2023
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Nov 15, 2023
@alextreme alextreme added the triage Issue needs to be validated. Remove this label if the issue considered valid. label Nov 15, 2023
@alextreme alextreme changed the title Objects API integration: pausing and restarting DigiD form causes hashed BSNs to be sent to the Objects API Objects API integration: pausing and restarting DigiD form causes hashed BSNs to be sent to the Objects API (only Demo BSN?) Nov 15, 2023
@joeribekker joeribekker added owner: den-haag and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 20, 2023
@joeribekker joeribekker added this to the Release 2.5.0 milestone Nov 20, 2023
@joeribekker
Copy link
Contributor

Refinement: Adding to milestone but low prio because it appears to only be happening with the demo plugin (which is still weird).

@alextreme
Copy link
Contributor Author

@joeribekker the Taiga issue was updated that Laurens was able to reproduce this by pauzing and restarting twice in combination with the DigiD-OIDC integration. As such it is more relevant than only the demo plugin.

@SilviaAmAm SilviaAmAm self-assigned this Nov 21, 2023
@SilviaAmAm
Copy link
Contributor

SilviaAmAm commented Nov 21, 2023

I could reproduce it by logging in with DigiD (OIDC), pausing/resuming the form, and then submitting the form.

Edit:

Found how to reproduce consistently also on other environments/plugins:

  • Create a form with a authentication plugin
  • Create a step that does NOT require login
  • Log in to fill in the form
  • Pause the form
  • Resume the form => Look in the submission, the BSN is hashed.

If the step DOES require login, then this problem does not happen.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Nov 29, 2023
SilviaAmAm added a commit that referenced this issue Nov 29, 2023
SilviaAmAm added a commit that referenced this issue Dec 1, 2023
SilviaAmAm added a commit that referenced this issue Dec 1, 2023
SilviaAmAm added a commit that referenced this issue Dec 1, 2023
SilviaAmAm added a commit that referenced this issue Dec 1, 2023
SilviaAmAm added a commit that referenced this issue Dec 1, 2023
…ogin

[#3613] Fix resuming submission when form does not require login
sergei-maertens added a commit that referenced this issue Dec 1, 2023
sergei-maertens added a commit that referenced this issue Dec 1, 2023
sergei-maertens added a commit that referenced this issue Dec 1, 2023
sergei-maertens added a commit that referenced this issue Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: den-haag
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants