Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5 testing notes #3616

Closed
23 of 24 tasks
Tracked by #3767
sergei-maertens opened this issue Nov 17, 2023 · 4 comments · Fixed by #3810
Closed
23 of 24 tasks
Tracked by #3767

Release 2.5 testing notes #3616

sergei-maertens opened this issue Nov 17, 2023 · 4 comments · Fixed by #3810
Assignees
Milestone

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Nov 17, 2023

I'm adding some notes for release-testing (by hand) that are relevant and need to be double/triple checked.

  • Hash based routing (or not) @SilviaAmAm
    • Validate against ODRU (see Taiga)
    • Embed a form in a "third party CMS" with hash based routing, on a subpath with the ?form=<form-id> query string
    • Ensure that a form can be started from this embed page
    • Ensure that a form can be paused and resumed from this embed page
    • Ensure that the co-sign flow still works (form with co-sign and have another person do the cosign check/confirmation)
    • Appointment with demo plugin
    • Check the appointment cancellation flow
  • Test the above flows in our own backend without hash based routing:
    • Pause and resume
    • Cosign
    • Appointment cancellation

Test task orchestration refactor @vaszig :

  • Test a form with payment and cosign:
    - Ensure that upon submitting the form, no confirmation email is sent but a cosign request is sent.
    - Upon payment, a confirmation email is sent
    - Upon cosign a confirmation email is sent with the cosigner in the CC
    - Check that registration works
  • Test a form without payment:
    - Upon completion the confirmation email is sent
  • Test retrying to register submissions
  • Test a form with appointments

Styling refactors: @SilviaAmAm

  • Styling tests when submitting a form as registrator on behalf of a customer

PDF generation: @SilviaAmAm

  • Check styling of confirmation/summary PDF (following WeasyPrint upgrade)

React 18 upgrade (#3697) @Viicos

  • Check form designer (tabbed interface, adding/modifying/removing components...)
  • Check form definition admin (add / edit)
  • Design token editor for style/theme page
  • Plugin configuration in global configuration page
  • Form versions, viewing + restoring
  • Session timeout widget (bottom right in admin, counter + popup)
@SilviaAmAm
Copy link
Contributor

SilviaAmAm commented Jan 23, 2024

SDK styling problems noticed:

  • Dropdown (missing the arrow and a bit too short): (@sergei-maertens)
    Screenshot from 2024-01-23 11-53-25
    Screenshot from 2024-01-23 11-54-09
  • The asterisk has moved further down
    Screenshot from 2024-01-23 11-58-37
  • Error styling in embedded form misses the red stripe on the left:
    Odru was still loading the CSS from their production environment (not on 2.5 yet)
    Screenshot from 2024-01-23 15-26-06

Admin styling problems noticed:

  • missing padding in form definition configuration (not present if edited via the form): @vaszig
    This was an existing error and will be tackled in the new design (Wontfix).

image

Backend frontend styling problems

  • The page to log in as administrator looks off: padding between fields/buttons, error styling: @SilviaAmAm
    Screenshot from 2024-01-23 12-51-57
    Screenshot from 2024-01-23 12-55-41

@Viicos
Copy link
Contributor

Viicos commented Jan 23, 2024

  • Empty time component can't be saved by default: the placeholder for min/max time is incorrect (same for datetime/date when Fixed value is set):
    image

  • Default value for cosign component says (this only work when the component was saved, and will happen when reopening it):
    image

@vaszig
Copy link
Contributor

vaszig commented Jan 23, 2024

  • Completion retry flag is not properly updated

Image

If we force a form with a registration to fail and then try to register again the submission in the admin, the registration succeeds but the flag still shows a red cross (needs_on_completion_retry=True - but it should be False)

Tested again and working as expected.

  • Generated pdf of an appointment has unresolved variables in it

Image

Viicos added a commit that referenced this issue Jan 24, 2024
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Jan 24, 2024
SilviaAmAm added a commit that referenced this issue Jan 24, 2024
SilviaAmAm added a commit that referenced this issue Jan 24, 2024
SilviaAmAm added a commit that referenced this issue Jan 24, 2024
SilviaAmAm added a commit that referenced this issue Jan 24, 2024
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Jan 24, 2024
SilviaAmAm added a commit that referenced this issue Jan 25, 2024
@sergei-maertens
Copy link
Member Author

sergei-maertens commented Jan 25, 2024

Embed a form in a "third party CMS" with hash based routing, on a subpath with the ?form=<form-id> query string

Tested and it's broken - the query string parameter does not get sent along to the backend (SDK issue).

edit: SDK 2.1.1 has the fix

sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 25, 2024
sergei-maertens added a commit that referenced this issue Jan 25, 2024
sergei-maertens added a commit that referenced this issue Jan 26, 2024
🐳 [#3616] Add docker-compose setup for embedding testing
sergei-maertens added a commit that referenced this issue Jan 26, 2024
…-report

[#3616] Fix PDF template of submission appointment
sergei-maertens pushed a commit that referenced this issue Jan 26, 2024
sergei-maertens pushed a commit that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants