Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select familymembers bugs out #3625

Closed
joeribekker opened this issue Nov 21, 2023 · 2 comments · Fixed by #3634
Closed

Select familymembers bugs out #3625

joeribekker opened this issue Nov 21, 2023 · 2 comments · Fixed by #3634
Assignees
@Viicos
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: utrecht
Milestone
Release 2.4.2

Comments

@joeribekker
Copy link
Contributor

Open Forms 2.4.1

Ref: Taiga Utr 76
Ref: Sentry 341872
@joeribekker joeribekker added the bug Something isn't working label Nov 21, 2023
@joeribekker joeribekker added this to the Release 2.4.2 milestone Nov 21, 2023
@sergei-maertens
Copy link
Member

sergei-maertens commented Nov 21, 2023 •
edited

Seems to be same problem as #3368 and #1617 is also relevant, see

open-forms/src/openforms/prefill/contrib/stufbg/plugin.py

Line 116 in 0e18a0f

if isinstance(value, dict) and "#text" in value:

We need a proper StUF handler for this sort of processing, types are not consistent of what we get back.

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Nov 21, 2023
@sergei-maertens
Copy link
Member

open-forms/src/stuf/stuf_bg/client.py

Line 79 in c5a2d38

def _remove_nils(d: M) -> M:
Looks generic but doesn't seem to handle the #text case linked above.

Viicos added a commit that referenced this issue Nov 28, 2023
@Viicos
[#3625] Fix handling of null values when parsing Stuf responses
dbc50dc
@Viicos Viicos mentioned this issue Nov 28, 2023
Merged
sergei-maertens added a commit that referenced this issue Nov 28, 2023
@sergei-maertens
Merge pull request #3634 from open-formulieren/issue/3625-stuf
92ea237 
[#3625] Fix handling of null values when parsing Stuf responses
sergei-maertens pushed a commit that referenced this issue Nov 28, 2023
@Viicos @sergei-maertens
[#3625] Fix handling of null values when parsing Stuf responses
47d24e9 
Backport-of: #3634
Viicos added a commit that referenced this issue Nov 28, 2023
@Viicos
[#3625] Fix handling of null values when parsing Stuf responses
b1f399e
sergei-maertens pushed a commit that referenced this issue Nov 28, 2023
@Viicos @sergei-maertens
[#3625] Fix handling of null values when parsing Stuf responses
443d84e 
Backport-of: #3634
sergei-maertens pushed a commit that referenced this issue Nov 28, 2023
@Viicos @sergei-maertens
[#3625] Fix handling of null values when parsing Stuf responses
9d8a9bd 
Backport-of: #3634
sergei-maertens pushed a commit that referenced this issue Nov 28, 2023
@Viicos @sergei-maertens
[#3625] Fix handling of null values when parsing Stuf responses
d2fbe8a 
Backport-of: #3634
@open-formulieren open-formulieren deleted a comment from Viicos Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viicos Viicos

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: utrecht
Projects
Development
Archived in project
Milestone
Release 2.4.2
Development

Successfully merging a pull request may close this issue.

[#3625] Fix handling of null values when parsing Stuf responses open-formulieren/open-forms
3 participants
@joeribekker @sergei-maertens @Viicos