Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosign V2 component configuration should not require authPlugin to be specified #3680

Closed
sergei-maertens opened this issue Dec 11, 2023 · 1 comment · Fixed by #3820, open-formulieren/open-forms-sdk#639, open-formulieren/types#41, open-formulieren/formio-builder#118 or open-formulieren/formio-builder#119
Closed

Cosign V2 component configuration should not require authPlugin to be specified #3680

sergei-maertens opened this issue Dec 11, 2023 · 1 comment · Fixed by #3820, open-formulieren/open-forms-sdk#639, open-formulieren/types#41, open-formulieren/formio-builder#118 or open-formulieren/formio-builder#119
Assignees
@SilviaAmAm
Labels
enhancement topic: form builder
Milestone
Release 2.6.0

Comments

@sergei-maertens
Copy link
Member

Thema / Theme

Form designer

Omschrijving / Description

Currently the cosign v2 component edit form requires you to specify the auth plugin to use for cosign, with the help text that it should be the same as used on the form itself for the primary person to authenticate.

image

This is obsolete configuration - if it really has to be the same method (digid vs. eherkenning etc.), then this information can be derived from the Submission instance itself since the method of authentication is recorded there. The form builder then does not need to specify it.

If it's a different method, the description is wrong, but Joeri & I both don't see a realistic use case for this.

Added value / Toegevoegde waarde

Less configuration options -> less confusion & no more risk of conflicting configuration and the associated runtime errors.

Aanvullende opmerkingen / Additional context

Noticed this will implementing the component in the new builder, which should also be updated once this issue is picked up.

I'm currently implementing this field still in the new builder, on the assumption that the backend is actually using the component configuration currently and removing it would introduce a breaking change.
@sergei-maertens sergei-maertens added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Dec 11, 2023
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Dec 18, 2023
@joeribekker joeribekker added this to the Release 2.6.0 milestone Dec 18, 2023
@SilviaAmAm SilviaAmAm self-assigned this Jan 22, 2024
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
🔥 [#3680] Remove authPlugin field from cosign component
abda9ce
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
📝 [#3680] Update stories for cosign component
873055a
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
♻️ [#3680] Replace cosign_login_info with cosign_login_options
1c3f400
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
✅ [#3680] Update tests
7036f60
@SilviaAmAm SilviaAmAm mentioned this issue Jan 26, 2024
Merged
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
🔥 [#3680] Remove authPlugin field from cosign component
392d454
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
📝 [#3680] Update stories for cosign component
b2c97ca
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
♻️ [#3680] Replace cosign_login_info with cosign_login_options
597b461
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
✅ [#3680] Update tests
2964d09
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 26, 2024
@SilviaAmAm
♻️ [open-formulieren/open-forms#3680] Updated the LoginOptions compon…
2c8907e 
…ents to deal with arrays for cosign login options
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 26, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3680] Updated tests/stories
6509247
@SilviaAmAm SilviaAmAm mentioned this issue Jan 26, 2024
Merged
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
📦 [#3680] Updated OAS
ee80032
SilviaAmAm added a commit to open-formulieren/types that referenced this issue Jan 26, 2024
@SilviaAmAm
🔥 [open-formulieren/open-forms#3680] Remove authPlugin from cosign V2
6836059
SilviaAmAm added a commit to open-formulieren/types that referenced this issue Jan 26, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3680] Update cosign V2 tests
79cbd13
@SilviaAmAm SilviaAmAm mentioned this issue Jan 26, 2024
Merged
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 26, 2024
@SilviaAmAm
♻️ [open-formulieren/open-forms#3680] Updated the LoginOptions compon…
67de66e 
…ents to deal with arrays for cosign login options
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 26, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3680] Updated tests/stories
9605fb9
SilviaAmAm added a commit to open-formulieren/formio-builder that referenced this issue Jan 26, 2024
@SilviaAmAm
🔥 [open-formulieren/open-forms#3680] Update default values cosign V2 …
f7bd4bb 
…component
SilviaAmAm added a commit to open-formulieren/formio-builder that referenced this issue Jan 26, 2024
@SilviaAmAm
📝 [open-formulieren/open-forms#3680] Update stories cosign V2 component
8ec9951
@SilviaAmAm SilviaAmAm mentioned this issue Jan 26, 2024
Merged
SilviaAmAm added a commit that referenced this issue Jan 26, 2024
@SilviaAmAm
🔥 [#3680] Remove authPlugin field from cosign component
758635a
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 31, 2024
@SilviaAmAm
♻️ [open-formulieren/open-forms#3680] Updated the LoginOptions compon…
9e87989 
…ents to deal with arrays for cosign login options
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 31, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3680] Updated tests/stories
2650602
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 31, 2024
@SilviaAmAm
👌 [open-formulieren/open-forms#3680] PR Feedback
a5819f8
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
🔥 [#3680] Remove authPlugin field from cosign component
3da1948
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
📝 [#3680] Update stories for cosign component
6520cbd
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
♻️ [#3680] Replace cosign_login_info with cosign_login_options
155adb5
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
✅ [#3680] Update tests
56d43df
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
⏪ [#3680] Add old field back but deprecate it
ccacb9b
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
✅ [#3680] Test deprecated field
9fbc1af
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
✏️ [#3680] Fix small frontend mistakes
6b0865e
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
⬆️ [#3680] Upgrade form-builder
b431648
SilviaAmAm added a commit to open-formulieren/formio-builder that referenced this issue Feb 1, 2024
@SilviaAmAm
🔥 [open-formulieren/open-forms#3680] Remove forgotten AuthPlugin comp…
d6cfdfa 
…onent
@SilviaAmAm SilviaAmAm mentioned this issue Feb 1, 2024
Merged
SilviaAmAm added a commit to open-formulieren/formio-builder that referenced this issue Feb 1, 2024
@SilviaAmAm
🔥 [open-formulieren/open-forms#3680] Remove forgotten AuthPlugin comp…
5fe89cc 
…onent
SilviaAmAm added a commit to open-formulieren/formio-builder that referenced this issue Feb 1, 2024
@SilviaAmAm
🔥 [open-formulieren/open-forms#3680] Remove forgotten AuthPlugin comp…
f87e52c 
…onent
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
⬆️ [#3680] Upgrade form-builder
0bda8b2
SilviaAmAm added a commit that referenced this issue Feb 1, 2024
@SilviaAmAm
👌 [#3680] PR Feedback
9bf93ac
@sergei-maertens
Copy link
Member Author

SDK PR still open

SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Feb 2, 2024
@SilviaAmAm
👌 [open-formulieren/open-forms#3680] Fix wrong type
7945fd8
sergei-maertens added a commit that referenced this issue Feb 5, 2024
@sergei-maertens
🐛 [#3680] Fix possible crash in form endpoint(s)
57bf4b3
SilviaAmAm added a commit that referenced this issue Feb 7, 2024
@SilviaAmAm
🔥 [#3680] Removed missed references to authPlugin
b3b8707
SilviaAmAm added a commit that referenced this issue Feb 7, 2024
@SilviaAmAm
✅ [#3680] Update tests
939147d
@SilviaAmAm SilviaAmAm mentioned this issue Feb 7, 2024
Merged
SilviaAmAm added a commit that referenced this issue Feb 7, 2024
@SilviaAmAm
🔥 [#3680] Removed missed references to authPlugin
132a901
SilviaAmAm added a commit that referenced this issue Feb 7, 2024
@SilviaAmAm
✅ [#3680] Update tests
14c9ed3
sergei-maertens added a commit that referenced this issue Feb 7, 2024
@sergei-maertens
Merge pull request #3850 from open-formulieren/fix/3680-missed-refere…
7c0c87e 
…nces-toauth-plugin

[#3680] Missed references to authPlugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
enhancement topic: form builder
Projects
Development
Archived in project
Milestone
Release 2.6.0
3 participants
@joeribekker @sergei-maertens @SilviaAmAm