Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DigiD-OIDC does not redirect to form if the user is authenticated and cancels the login #3692

Closed
vaszig opened this issue Dec 15, 2023 · 0 comments · Fixed by #3696
Closed

DigiD-OIDC does not redirect to form if the user is authenticated and cancels the login #3692

vaszig opened this issue Dec 15, 2023 · 0 comments · Fixed by #3696
Assignees
@SilviaAmAm
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: dimpact
Milestone
Release 2.5.0

Comments

@vaszig
Copy link
Contributor

vaszig commented Dec 15, 2023

Product versie / Product version

latest

Omschrijf het probleem / Describe the bug

When a user is authenticated, for example an admin user is logged in and clicks on a form which uses DigiD-OIDC authentication, if he cancels the login flow then the site crashes (KeyError - there is no next-url).

Sentry: 336625

Stappen om te reproduceren / Steps to reproduce

  1. Create a form which uses DigiD-OIDC authentication
  2. Click on show form and then on the startpage of the form, try to log in
  3. Being on the selection page (DigiD, Eherkenning etc) click cancel

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response
@vaszig vaszig added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Dec 15, 2023
@vaszig vaszig self-assigned this Dec 15, 2023
@vaszig vaszig added owner: dimpact and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Dec 15, 2023
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Dec 15, 2023
vaszig added a commit that referenced this issue Dec 15, 2023
@vaszig
[#3692] Fixed next url when authenticated user cancels login
95c2cae
@vaszig vaszig mentioned this issue Dec 15, 2023
Merged
vaszig added a commit that referenced this issue Dec 15, 2023
@vaszig
[#3692] Added test for authenticated user
14ffca5
vaszig added a commit that referenced this issue Dec 15, 2023
@vaszig
[#3692] Fixed import sorting
8b3cb94
vaszig added a commit that referenced this issue Dec 18, 2023
@vaszig
[#3692] Fixed next url when authenticated user cancels login
75227d0
vaszig added a commit that referenced this issue Dec 18, 2023
@vaszig
[#3692] Added test for authenticated user
a57a24a
vaszig added a commit that referenced this issue Dec 18, 2023
@vaszig
[#3692] Fixed import sorting
033d771
vaszig added a commit that referenced this issue Dec 18, 2023
@vaszig
[#3692] Fixed next url when authenticated user cancels login
d2cc1e5
@joeribekker joeribekker linked a pull request Dec 18, 2023 that will close this issue
[#3692] Fix next url when authenticated user cancels login #3696
Merged
vaszig added a commit that referenced this issue Dec 19, 2023
@vaszig
[#3692] Fixed next url when authenticated user cancels login
f66d621
vaszig added a commit that referenced this issue Dec 19, 2023
@vaszig
[#3692] Added test for authenticated user
74e3f8b
vaszig added a commit that referenced this issue Dec 19, 2023
@vaszig
[#3692] Fixed import sorting
52c2cae
vaszig added a commit that referenced this issue Dec 19, 2023
@vaszig
[#3692] Fixed next url when authenticated user cancels login
584e49f
vaszig added a commit that referenced this issue Dec 19, 2023
@vaszig
[#3692] Fixed next url when authenticated user cancels login
5b9a224
sergei-maertens pushed a commit that referenced this issue Dec 21, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
f7f7b44
sergei-maertens pushed a commit that referenced this issue Dec 21, 2023
@vaszig @sergei-maertens
[#3692] Added test for authenticated user
08c81f3
sergei-maertens pushed a commit that referenced this issue Dec 21, 2023
@vaszig @sergei-maertens
[#3692] Fixed import sorting
20790b6
sergei-maertens pushed a commit that referenced this issue Dec 21, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
bbabff6
sergei-maertens pushed a commit that referenced this issue Dec 21, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
8ab63b9
@joeribekker joeribekker added this to the Release 2.5.0 milestone Dec 28, 2023
@sergei-maertens sergei-maertens assigned SilviaAmAm and unassigned vaszig Dec 28, 2023
SilviaAmAm pushed a commit that referenced this issue Dec 28, 2023
@vaszig @SilviaAmAm
[#3692] Fixed next url when authenticated user cancels login
0876118
SilviaAmAm pushed a commit that referenced this issue Dec 28, 2023
@vaszig @SilviaAmAm
[#3692] Added test for authenticated user
8c6b50b
SilviaAmAm pushed a commit that referenced this issue Dec 28, 2023
@vaszig @SilviaAmAm
[#3692] Fixed import sorting
6c784e0
SilviaAmAm pushed a commit that referenced this issue Dec 28, 2023
@vaszig @SilviaAmAm
[#3692] Fixed next url when authenticated user cancels login
80bd139
SilviaAmAm pushed a commit that referenced this issue Dec 28, 2023
@vaszig @SilviaAmAm
[#3692] Fixed next url when authenticated user cancels login
19be051
SilviaAmAm added a commit that referenced this issue Dec 28, 2023
@SilviaAmAm
👌 [#3692] PR Feedback
71eaf6f
SilviaAmAm added a commit that referenced this issue Dec 28, 2023
@SilviaAmAm
👌 [#3692] PR Feedback
47c75dd
sergei-maertens pushed a commit that referenced this issue Dec 28, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
a7f0a99
sergei-maertens pushed a commit that referenced this issue Dec 28, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
c94654a 
Backport-of: #3696
Co-authored-by: @SilviaAmAm
sergei-maertens pushed a commit that referenced this issue Dec 28, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
05d3823 
Backport-of: #3696
Co-authored-by: @SilviaAmAm
sergei-maertens pushed a commit that referenced this issue Dec 28, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
5ee9426 
Backport-of: #3696
Co-authored-by: @SilviaAmAm
sergei-maertens pushed a commit that referenced this issue Dec 28, 2023
@vaszig @sergei-maertens
[#3692] Fixed next url when authenticated user cancels login
a700a2a 
Backport-of: #3696
Co-authored-by: @SilviaAmAm
sergei-maertens added a commit that referenced this issue Dec 28, 2023
@sergei-maertens
Merge pull request #3696 from open-formulieren/fix/3692-digid-oidc-au…
7047994 
…thenticated-user-not-redirected-to-form-after-cancel

[#3692] Fix next url when authenticated user cancels login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: dimpact
Projects
Development
Archived in project
Milestone
Release 2.5.0
Development

Successfully merging a pull request may close this issue.

[#3692] Fix next url when authenticated user cancels login open-formulieren/open-forms
4 participants
@joeribekker @sergei-maertens @SilviaAmAm @vaszig