New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 18 #3694

Closed

sergei-maertens opened this issue Dec 15, 2023 · 0 comments · Fixed by #3697

Assignees

Milestone

Member

sergei-maertens commented Dec 15, 2023

Now storybook is updated to v7, we can upgrade React from 17 to 18.

This in turn will allow us to upgrade/develop the form builder for React 18+ and hopefully simplify version management.

sergei-maertens added this to the Release 2.5.0 milestone

sergei-maertens self-assigned this

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump React from v17 to v18

ef53b0e

sergei-maertens added a commit that referenced this issue


          👽 [#3694] Replace ReactDOM.render with createRoot + render

c219ffa

sergei-maertens added a commit that referenced this issue


          ♻️ [#3694] Centralize common component wrapping when mounting roots

5313a40

Most of the time we're passing the same/similar context to the component
we're actually rendering, so it makes sense to make this a common wrapper
component.

The form-creation-form stuff doesn't play nice with strict mode yet, there
are unintended side-effects being performed in places (formio.js for sure)
that trip immer. So, for the time being, strict mode can be disabled.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump tinymce-react to latest version

1d56800

3.14+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump react-modal to latest version

48083d0

3.15+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Upgrade react-tabs to latest version

1d787bc

v5.0+ is required for React 18 support.

sergei-maertens mentioned this issue

Upgrade to React 18 #3697

Merged

sergei-maertens added a commit that referenced this issue


          👽 [#3694] Replace ReactDOM.render with createRoot + render

e01f42c

sergei-maertens added a commit that referenced this issue


          ♻️ [#3694] Centralize common component wrapping when mounting roots

915ab41

Most of the time we're passing the same/similar context to the component
we're actually rendering, so it makes sense to make this a common wrapper
component.

The form-creation-form stuff doesn't play nice with strict mode yet, there
are unintended side-effects being performed in places (formio.js for sure)
that trip immer. So, for the time being, strict mode can be disabled.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump tinymce-react to latest version

bd3b538

3.14+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump react-modal to latest version

dbd0864

3.15+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Upgrade react-tabs to latest version

7de4c9b

v5.0+ is required for React 18 support.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump React from v17 to v18

6cfb318

sergei-maertens added a commit that referenced this issue


          👽 [#3694] Replace ReactDOM.render with createRoot + render

2af09bd

sergei-maertens added a commit that referenced this issue


          ♻️ [#3694] Centralize common component wrapping when mounting roots

623169b

Most of the time we're passing the same/similar context to the component
we're actually rendering, so it makes sense to make this a common wrapper
component.

The form-creation-form stuff doesn't play nice with strict mode yet, there
are unintended side-effects being performed in places (formio.js for sure)
that trip immer. So, for the time being, strict mode can be disabled.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump tinymce-react to latest version

855de34

3.14+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump react-modal to latest version

cd8a05e

3.15+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Upgrade react-tabs to latest version

ec4c816

v5.0+ is required for React 18 support.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump React from v17 to v18

37b3d0b

sergei-maertens added a commit that referenced this issue


          👽 [#3694] Replace ReactDOM.render with createRoot + render

2de3b27

sergei-maertens added a commit that referenced this issue


          ♻️ [#3694] Centralize common component wrapping when mounting roots

acfac38

Most of the time we're passing the same/similar context to the component
we're actually rendering, so it makes sense to make this a common wrapper
component.

The form-creation-form stuff doesn't play nice with strict mode yet, there
are unintended side-effects being performed in places (formio.js for sure)
that trip immer. So, for the time being, strict mode can be disabled.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump tinymce-react to latest version

20cde2c

3.14+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump react-modal to latest version

e6e6012

3.15+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Upgrade react-tabs to latest version

acc0fcf

v5.0+ is required for React 18 support.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump React from v17 to v18

01368b7

sergei-maertens added a commit that referenced this issue


          👽 [#3694] Replace ReactDOM.render with createRoot + render

2a73858

sergei-maertens added a commit that referenced this issue


          ♻️ [#3694] Centralize common component wrapping when mounting roots

4d2ee5d

Most of the time we're passing the same/similar context to the component
we're actually rendering, so it makes sense to make this a common wrapper
component.

The form-creation-form stuff doesn't play nice with strict mode yet, there
are unintended side-effects being performed in places (formio.js for sure)
that trip immer. So, for the time being, strict mode can be disabled.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump tinymce-react to latest version

5e1a402

3.14+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Bump react-modal to latest version

a29c31e

3.15+ supports React 18.

sergei-maertens added a commit that referenced this issue


          ⬆️ [#3694] Upgrade react-tabs to latest version

4477a03

v5.0+ is required for React 18 support.

sergei-maertens closed this as completed in #3697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment