Upgrade formio-builder #3712
Assignees
Comments
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Required fixes/additions: * Pass the list of pre-configured colors from the backend to the rich text component edit form via the context * Due to the special tabbed layout for the content component, a CSS override is required to make sure tabbed cards can be stacked without taking up too much blank space * Polyfill needed for the :has selector used in the above bullet, since Firefox only supports it since v121 which was released only 8 days ago * The e2e test for the content translations needs to be overridden because the layout is substantially different (better!) * The cosign components need access to the available auth plugins. The utility is implemented in the cosign v2 component definition, similarly to how this is done for the file component. Once we drop our edit form definitions in favour of the new formio builder (i.e. it is no longer experimental), we can clean up this code more.
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Formio itself bundles/works with CKEditor 19, so using a newer version breaks some things. Fixed in this override is: * setting the readonly mode of the editor, now via a method * setting the style (height) of the editable div, using the editor.editing.view interface rather than the editableElement (which no longer exists) * we already bundle the ClassicEditor through our own builder build, but additionally assign it to the global window object to prevent Formio from trying to load the older version from its own CDN. You cannot include multiple builds of a CKEditor into the same page, so using both v19 and v40 together crashes either the legacy or the new formio builder.
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Existing components and old forms being imported on newer instances automatically upgrade to have the default property set, as the new form builder expects this.
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Required fixes/additions: * Pass the list of pre-configured colors from the backend to the rich text component edit form via the context * Due to the special tabbed layout for the content component, a CSS override is required to make sure tabbed cards can be stacked without taking up too much blank space * Polyfill needed for the :has selector used in the above bullet, since Firefox only supports it since v121 which was released only 8 days ago * The e2e test for the content translations needs to be overridden because the layout is substantially different (better!) * The cosign components need access to the available auth plugins. The utility is implemented in the cosign v2 component definition, similarly to how this is done for the file component. Once we drop our edit form definitions in favour of the new formio builder (i.e. it is no longer experimental), we can clean up this code more.
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Formio itself bundles/works with CKEditor 19, so using a newer version breaks some things. Fixed in this override is: * setting the readonly mode of the editor, now via a method * setting the style (height) of the editable div, using the editor.editing.view interface rather than the editableElement (which no longer exists) * we already bundle the ClassicEditor through our own builder build, but additionally assign it to the global window object to prevent Formio from trying to load the older version from its own CDN. You cannot include multiple builds of a CKEditor into the same page, so using both v19 and v40 together crashes either the legacy or the new formio builder.
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Existing components and old forms being imported on newer instances automatically upgrade to have the default property set, as the new form builder expects this.
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Merged
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
sergei-maertens
added a commit
that referenced
this issue
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: