Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/update outdated section of docs regarding extensions #3735

Closed
Viicos opened this issue Jan 4, 2024 · 0 comments · Fixed by #3962
Closed

Remove/update outdated section of docs regarding extensions #3735

Viicos opened this issue Jan 4, 2024 · 0 comments · Fixed by #3962
Assignees
@sergei-maertens
Labels
documentation Improvements or additions to documentation
Milestone
Release 2.6.0

Comments

@Viicos
Copy link
Contributor

Viicos commented Jan 4, 2024

Product versie / Product version

latest

Omschrijf het probleem / Describe the bug

This section of the docs is outdated:

open-forms/docs/developers/extensions.rst

Lines 40 to 44 in d931ceb

#. Open Forms requests prefill data from Haal Centraal:
* The client that makes the request to the ZGW API is :class:`openforms.pre_requests.clients.PreRequestZGWClient`.
This client is a subclass of :class:`zgw_consumers.client.ZGWClient` which overrides the ``pre_request`` method so
that any pre-request hooks registered in Open Forms are run before performing the request.

(there isn't any PreRequestZGWClient class anymore)

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response
@Viicos Viicos added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 4, 2024
@joeribekker joeribekker changed the title Remove/update oudated section of docs regarding extensions Remove/update outdated section of docs regarding extensions Jan 8, 2024
@joeribekker joeribekker added documentation Improvements or additions to documentation and removed bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jan 8, 2024
@joeribekker joeribekker added this to the Release 2.5.0 milestone Jan 8, 2024
@sergei-maertens sergei-maertens removed this from the Release 2.5.0 milestone Jan 12, 2024
@joeribekker joeribekker added this to the Release 2.6.0 milestone Jan 29, 2024
sergei-maertens added a commit that referenced this issue Mar 1, 2024
@sergei-maertens
📝 [#3735] Update documentation about pre-request clients
a2cdb83
@sergei-maertens sergei-maertens mentioned this issue Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
documentation Improvements or additions to documentation
Projects
Development
Archived in project
Milestone
Release 2.6.0
Development

Successfully merging a pull request may close this issue.

Update documentation about pre-request clients open-formulieren/open-forms
3 participants
@joeribekker @sergei-maertens @Viicos