Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if content-component is rendered properly in summary page #3778

Closed
joeribekker opened this issue Jan 15, 2024 · 2 comments · Fixed by #3786 or open-formulieren/open-forms-sdk#635
Closed

Check if content-component is rendered properly in summary page #3778

joeribekker opened this issue Jan 15, 2024 · 2 comments · Fixed by #3786 or open-formulieren/open-forms-sdk#635
Assignees
@SilviaAmAm
Labels
enhancement
Milestone
Release 2.5.0

Comments

@joeribekker
Copy link
Contributor

Ref. DH 88
@joeribekker joeribekker added this to the Release 2.5.0 milestone Jan 15, 2024
@SilviaAmAm
Copy link
Contributor

It is rendered without formatting:

Image
Image

@joeribekker
Copy link
Contributor Author

This is ok, but it should not show the label. I think Sergei had worked on this, check PRs. If not, please remove the label.

SilviaAmAm added a commit that referenced this issue Jan 18, 2024
@SilviaAmAm
🐛 [#3778] Render empty string for content component label
31ec5a0
SilviaAmAm added a commit that referenced this issue Jan 18, 2024
@SilviaAmAm
✅ [#3778] Test empty label for content component
0659610
@SilviaAmAm SilviaAmAm mentioned this issue Jan 18, 2024
Merged
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
🐛 [open-formulieren/open-forms#3778] Content component should not ren…
91f741a 
…der name
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3778] Test summary of fields with empt…
68d518d 
…y names
@SilviaAmAm SilviaAmAm mentioned this issue Jan 18, 2024
Merged
SilviaAmAm added a commit that referenced this issue Jan 19, 2024
@SilviaAmAm
Merge pull request #3786 from open-formulieren/fix/3778-label-content…
b6ef8f5 
…-component

[#3778] Render empty label for content component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
enhancement
Projects
Development
Archived in project
Milestone
Release 2.5.0
2 participants
@joeribekker @SilviaAmAm