-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two forms with a re-usable form definition "sometimes" leads to an incorrect form in one of the two #3881
Comments
Refinement: suspicion is that updating a form variable via form X does not result in the same update being saved on form variable in form Y that also happens to use the same reusable form definition. Form variables are persisted in bulk in one transaction ( Remarks: this is bigger than just the prefill-configuration being out of sync, it also affects logic, registration, e.g. when:
We have a warning in the frontend that says X number of forms will be affected by changing the reusable form definition. However, because prefill is configured on the component itself (and synced/copied to the variable), the impression is that this will automatically apply to all forms using this form definition and the warning does not absolve us from properly handling this. So, we scope this to sychronizing variable configuration for this particular form definition (i.e. there is a match on form_definition FK, we nuke existing variables and recreate the new ones). Tasks:
|
Backport label added - let's aim for this, but we should not compromise the fix/implementation to make it backportable. Manual fixing is possible, so needs-backport is to be nice to customers :) |
When there is a reusable definition and we update the form variables, we want to kick off a celery task which will update all the forms which use the same definition.
When there is a reusable definition and we update the form variables, we want to kick off a celery task which will update all the forms which use the same definition.
When there is a reusable definition and we update the form variables, we want to kick off a celery task which will update all the forms which use the same form definition.
When there is a reusable definition and we update the form variables, we want to kick off a celery task which will update all the forms which use the same form definition.
…usable-form-definition-may-be-incorrect [#3881] Update variables in reusable form definitions
When there is a reusable definition and we update the form variables, we want to kick off a celery task which will update all the forms which use the same form definition. Backport-of: #3991
When there is a reusable definition and we update the form variables, we want to kick off a celery task which will update all the forms which use the same form definition. Backport-of: #3991
When there is a reusable definition and we update the form variables, we want to kick off a celery task which will update all the forms which use the same form definition. Backport-of: #3991
We found this issue when figuring out why voorletters was suddenly not working in the prefill when migrating from 2.4.3 to 2.4.5.
The client said it didn't work. Made the initials field writable (it was readonly) so it could be filled, and saved the form (this step was a re-usable form definition). When we tested it, it worked. Silvia suggested it could be related to a variable not being created and it was then created when the form was saved, making the form function.
This might also be the case why a re-usable form definition works in form A but not in form B, after the form definition is changed in form A.
The text was updated successfully, but these errors were encountered: