-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow hidden fields to be sent to registration systems #3890
Comments
I left triage label but also added it to the sprint because Utrecht needs this but I can also see it conflicting with #3688 |
https://github.com/open-formulieren/open-forms/blame/master/src/openforms/formio/rendering/structured.py - this seems to skip the hidden fields/nodes which is unfortunate if you're trying to register submission data to the objects API :) |
Refinement: the new registration mechanism in the objects API will not be able to handle The fix should be rather straight forward. |
…den-fields-to-be-sent-to-registration-systems [#3890] Allow hidden fields to be sent to registration systems
While the original bug report expects/states that the hidden fields should not be included at all in the objects API data, this is not actually a bug but a deliberate action - it was patched in #3890. It was never intentional to *not* send (the values) of hidden fields. This does however mean that the defined object type JSON schema's need to be updated to account for possible empty values, where the data type of empty is determined by the component type of the field (e.g. number and currency are 'null', but textfield is always going to be string). What *was* broken however, is that missing values were always sent as `null\' rather than the empty value that's component specific. There is an additional report of an entire fieldset being hidden resulting in the values not being sent, so that will require patching too.
While the original bug report expects/states that the hidden fields should not be included at all in the objects API data, this is not actually a bug but a deliberate action - it was patched in #3890. It was never intentional to *not* send (the values) of hidden fields. This does however mean that the defined object type JSON schema's need to be updated to account for possible empty values, where the data type of empty is determined by the component type of the field (e.g. number and currency are 'null', but textfield is always going to be string). What *was* broken however, is that missing values were always sent as `null\' rather than the empty value that's component specific. There is an additional report of an entire fieldset being hidden resulting in the values not being sent, so that will require patching too.
While the original bug report expects/states that the hidden fields should not be included at all in the objects API data, this is not actually a bug but a deliberate action - it was patched in #3890. It was never intentional to *not* send (the values) of hidden fields. This does however mean that the defined object type JSON schema's need to be updated to account for possible empty values, where the data type of empty is determined by the component type of the field (e.g. number and currency are 'null', but textfield is always going to be string). What *was* broken however, is that missing values were always sent as `null\' rather than the empty value that's component specific. There is an additional report of an entire fieldset being hidden resulting in the values not being sent, so that will require patching too.
While the original bug report expects/states that the hidden fields should not be included at all in the objects API data, this is not actually a bug but a deliberate action - it was patched in #3890. It was never intentional to *not* send (the values) of hidden fields. This does however mean that the defined object type JSON schema's need to be updated to account for possible empty values, where the data type of empty is determined by the component type of the field (e.g. number and currency are 'null', but textfield is always going to be string). What *was* broken however, is that missing values were always sent as `null\' rather than the empty value that's component specific. There is an additional report of an entire fieldset being hidden resulting in the values not being sent, so that will require patching too. Backport-of: #4123
Thema / Theme
Admin
Omschrijving / Description
Hidden fields are currently not sent to the registration backend. Can we make this happen, optionally?
Request comes from Utrecht who wants this, using the Objects API where it's added to
{{ data }}
so it automatically ends up in the registration system. It was not enough that they could manually add it elsewhere in the JSON field.Added value / Toegevoegde waarde
No response
Aanvullende opmerkingen / Additional context
No response
The text was updated successfully, but these errors were encountered: